Sonar

jbarnsley10 · jbarnsley10 · commit 739738418d7e · 2026-05-19T12:16:39.000+01:00
diff --git a/src/client/javascripts/geospatial-map.js b/src/client/javascripts/geospatial-map.js
@@ -67,10 +67,6 @@ function getAllowedTypesPhrase(allowPoint, allowLine, allowShape) {
     items.push('shapes')
   }
 
-  if (items.length === 0) {
-    return ''
-  }
-
   return formatDelimtedList(items, ',', 'or')
 }
 
diff --git a/src/client/javascripts/utils.js b/src/client/javascripts/utils.js
@@ -18,5 +18,6 @@ export function formatDelimtedList(items, separator, lastSpearator) {
   }
 
   const last = items.pop()
-  return `${items.join(`${separator} `)} ${lastSpearator} ${last}`
+  const separatorAndSpace = `${separator} `
+  return `${items.join(separatorAndSpace)} ${lastSpearator} ${last}`
 }

Original file line number	Diff line number	Diff line change
`@@ -67,10 +67,6 @@ function getAllowedTypesPhrase(allowPoint, allowLine, allowShape) {`
`67`	`67`	`items.push('shapes')`
`68`	`68`	`}`
`69`	`69`
`70`		`- if (items.length === 0) {`
`71`		`- return ''`
`72`		`- }`
`73`		`-`
`74`	`70`	`return formatDelimtedList(items, ',', 'or')`
`75`	`71`	`}`
`76`	`72`
Original file line number	Diff line number	Diff line change
`@@ -18,5 +18,6 @@ export function formatDelimtedList(items, separator, lastSpearator) {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`const last = items.pop()`
`21`		- return `${items.join(`${separator} `)} ${lastSpearator} ${last}`
	`21`	+ const separatorAndSpace = `${separator} `
	`22`	+ return `${items.join(separatorAndSpace)} ${lastSpearator} ${last}`
`22`	`23`	`}`