Prevent ID being set on list-based components temporarily

Author: alexluckett

src/server/plugins/engine/components/List.test.ts

@@ -52,21 +52,18 @@ describe('List', () => {
       it('returns list items', () => {
         expect(guidance).toHaveProperty('items', [
           {
-            id: '52fc51fc-c75a-4b08-9c9e-6bd99b9bc49b',
             text: '1 day',
             value: 1,
             description:
               'Valid for 24 hours from the start time that you select'
           },
           {
-            id: '56b7b34f-23b3-4446-ac8e-b2443d18588e',
             text: '8 day',
             value: 8,
             description:
               'Valid for 8 consecutive days from the start time that you select'
           },
           {
-            id: '1af54fbc-eec2-4e1e-bd53-2415abf62677',
             text: '12 months',
             value: 365,
             description:

src/server/plugins/engine/components/ListFormComponent.ts

@@ -48,7 +48,12 @@ export class ListFormComponent extends FormComponent {
   listType: List['type'] = 'string'
 
   get items(): Item[] {
-    return this.list?.items ?? []
+    return (
+      this.list?.items.map((item) => {
+        delete item.id // temporary workaround to prevent an ID being set, which invalidates #componentName fragments in the links
+        return item
+      }) ?? []
+    )
   }
 
   get values(): Item['value'][] {

src/server/plugins/engine/pageControllers/QuestionPageController.test.ts

@@ -443,15 +443,13 @@ describe('QuestionPageController', () => {
       expect(filtered[1].model.label?.text).toBe('Select from the list')
       expect(filtered[1].model.items).toEqual([
         {
-          id: expect.any(String),
           checked: false,
           condition: 'isBarnOwl',
           selected: false,
           text: 'Option 1',
           value: '1'
         },
         {
-          id: expect.any(String),
           checked: false,
           condition: 'isBarnOwl',
           selected: false,
@@ -501,15 +499,13 @@ describe('QuestionPageController', () => {
       expect(filtered[1].model.label?.text).toBe('Select from the list')
       expect(filtered[1].model.items).toEqual([
         {
-          id: expect.any(String),
           checked: false,
           condition: 'notBarnOwl',
           selected: false,
           text: 'Option 3',
           value: '3'
         },
         {
-          id: expect.any(String),
           checked: false,
           condition: 'notBarnOwl',
           selected: false,

test/form/factory.js

@@ -5,7 +5,6 @@
  */
 export function createListItemFactory(partialListItem) {
   return {
-    id: '52fc51fc-c75a-4b08-9c9e-6bd99b9bc49b',
     text: 'text',
     value: 1,
     description: 'Valid for 24 hours from the start time that you select',
@@ -20,7 +19,6 @@ export function createListItemFactory(partialListItem) {
  */
 export function createListFromFactory(partialList) {
   return {
-    id: '4ebe4ef5-bd3c-499b-a179-7e7e86b0dc6f',
     name: 'licenceLengthDays',
     title: 'Licence length (days)',
     type: 'number',