Created function to do pence to pounds conversion

Author: jbarnsley10

src/server/plugins/engine/routes/payment-helper.js

@@ -63,6 +63,13 @@ export function buildPaymentInfo(
   }
 }
 
+/**
+ * @param {number} amount
+ */
+export function convertPenceToPounds(amount) {
+  return `${amount / 100}`
+}
+
 /**
  * @import { Request } from '@hapi/hapi'
  * @import { GetPaymentResponse, PaymentSessionData } from '~/src/server/plugins/payment/types.js'

src/server/plugins/engine/routes/payment.js

@@ -6,6 +6,7 @@ import { createLogger } from '~/src/server/common/helpers/logging/logger.js'
 import { EXTERNAL_STATE_APPENDAGE } from '~/src/server/constants.js'
 import {
   buildPaymentInfo,
+  convertPenceToPounds,
   getPaymentContext
 } from '~/src/server/plugins/engine/routes/payment-helper.js'
 
@@ -64,7 +65,7 @@ function logPaymentSuccess(session, paymentStatus) {
     buildPaymentInfo(
       'pre-auth',
       'success',
-      `${paymentStatus.state.status} amount=${paymentStatus.amount / 100}`,
+      `${paymentStatus.state.status} amount=${convertPenceToPounds(paymentStatus.amount)}`,
       session.isLivePayment,
       paymentStatus.paymentId
     ),
@@ -82,7 +83,7 @@ function logPaymentFailure(session, paymentStatus) {
     buildPaymentInfo(
       'pre-auth',
       'failed/cancelled',
-      `${paymentStatus.state.status} amount=${paymentStatus.amount / 100}`,
+      `${paymentStatus.state.status} amount=${convertPenceToPounds(paymentStatus.amount)}`,
       session.isLivePayment,
       paymentStatus.paymentId
     ),

src/server/plugins/payment/service.js

@@ -1,7 +1,10 @@
 import { StatusCodes } from 'http-status-codes'
 
 import { createLogger } from '~/src/server/common/helpers/logging/logger.js'
-import { buildPaymentInfo } from '~/src/server/plugins/engine/routes/payment-helper.js'
+import {
+  buildPaymentInfo,
+  convertPenceToPounds
+} from '~/src/server/plugins/engine/routes/payment-helper.js'
 import { get, post, postJson } from '~/src/server/services/httpService.js'
 
 const PAYMENT_BASE_URL = 'https://publicapi.payments.service.gov.uk'
@@ -60,7 +63,7 @@ export class PaymentService {
       buildPaymentInfo(
         'create-payment',
         'success',
-        `amount=${amount / 100}`,
+        `amount=${convertPenceToPounds(amount)}`,
         isLivePayment,
         response.payment_id
       ),
@@ -156,7 +159,7 @@ export class PaymentService {
               category: 'payment',
               action: 'capture-payment',
               outcome: 'success',
-              reason: `amount=${amount / 100}`,
+              reason: `amount=${convertPenceToPounds(amount)}`,
               reference: paymentId
             }
           },