drop Promise.resolve as async is not neccessary any more

Author: alexluckett

src/server/plugins/nunjucks/context.js

@@ -72,7 +72,7 @@ export async function context(request) {
 /**
  * Returns the context for the devtool. Consumers won't have access to this.
  * @param {FormRequest | FormRequestPayload | null} _request
- * @returns {Promise<Record<string, unknown> & { assetPath: string, getDxtAssetPath: (asset: string) => string }>}
+ * @returns {Record<string, unknown> & { assetPath: string, getDxtAssetPath: (asset: string) => string }}
  */
 export function devtoolContext(_request) {
   const manifestPath = join(config.get('publicDir'), 'assets-manifest.json')
@@ -86,12 +86,12 @@ export function devtoolContext(_request) {
     }
   }
 
-  return Promise.resolve({
+  return {
     assetPath: '/assets',
     getDxtAssetPath: (asset = '') => {
       return `/${webpackManifest?.[asset] ?? asset}`
     }
-  })
+  }
 }
 
 /**

src/server/plugins/nunjucks/context.test.js

@@ -9,15 +9,15 @@ describe('Nunjucks context', () => {
   beforeEach(() => jest.resetModules())
 
   describe('Asset path', () => {
-    it("should include 'assetPath' for GOV.UK Frontend icons", async () => {
-      const { assetPath } = await devtoolContext(null)
+    it("should include 'assetPath' for GOV.UK Frontend icons", () => {
+      const { assetPath } = devtoolContext(null)
       expect(assetPath).toBe('/assets')
     })
   })
 
   describe('Asset helper', () => {
-    it("should locate 'assets-manifest.json' assets", async () => {
-      const { getDxtAssetPath } = await devtoolContext(null)
+    it("should locate 'assets-manifest.json' assets", () => {
+      const { getDxtAssetPath } = devtoolContext(null)
 
       expect(getDxtAssetPath('example.scss')).toBe(
         '/stylesheets/example.xxxxxxx.min.css'
@@ -39,16 +39,16 @@ describe('Nunjucks context', () => {
 
         // Update config for missing manifest
         config.set('publicDir', tmpdir())
-        const { getDxtAssetPath } = await devtoolContext(null)
+        const { getDxtAssetPath } = devtoolContext(null)
 
         // Uses original paths when missing
         expect(getDxtAssetPath('example.scss')).toBe('/example.scss')
         expect(getDxtAssetPath('example.mjs')).toBe('/example.mjs')
       })
     })
 
-    it('should return path to unknown assets', async () => {
-      const { getDxtAssetPath } = await devtoolContext(null)
+    it('should return path to unknown assets', () => {
+      const { getDxtAssetPath } = devtoolContext(null)
 
       expect(getDxtAssetPath('')).toBe('/')
       expect(getDxtAssetPath('example.jpg')).toBe('/example.jpg')