Apply a joi.array.min to non-optional file upload fields#308
Merged
davidjamesstone merged 2 commits intomainfrom Feb 12, 2026
Merged
Apply a joi.array.min to non-optional file upload fields#308davidjamesstone merged 2 commits intomainfrom
davidjamesstone merged 2 commits intomainfrom
Conversation
e2817dd to
119a83c
Compare
mokhld
approved these changes
Feb 11, 2026
|
alexluckett
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
An issue has been raised where a form was able to be submitted without any files for a
requiredfileuploadfieldThis is because an empty array passes the formSchema (
joi.array().required()) so the submission looks valid.This PR adds a default
joi.array.min(1)when aminis not explicitly provided through the designer and the field is not optional.https://defra-digital-team.slack.com/archives/C06E46GB1HA/p1770299635053199
Jira ticket:
https://eaflood.atlassian.net/browse/DF-843
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).