chore: dependency management#421
Open
alexluckett wants to merge 27 commits into
Open
Conversation
alexluckett
force-pushed
the
chore/dependency-management-2026-06-05
branch
from
6d8996f to
b6842be
Compare
…es for local development
Plugin targets govuk-frontend v6.2.0 features; ^6.0.0 would have allowed consumers to satisfy the peer with an older minor.
govukHeader no longer accepts serviceName/serviceUrl in v6; move them to govukServiceNavigation as per the updated design system.
alexluckett
force-pushed
the
chore/dependency-management-2026-06-05
branch
from
3f3250c to
8ad9386
Compare
joi was reverted to v17; these casts were only needed for v18's stricter type inference and are not required (or correct) on v17.
…gement-2026-06-05
govuk-frontend v6 dropped the value param from govukFileUpload entirely. The override was a workaround for v5's template rendering a truthy FileState object as value="[object Object]" on the input.
- govukSkipLink block instead of skipLink - containerStart block instead of beforeContent
Overriding the outer header/footer blocks bypassed the v6 template's _govukTemplateHeader and _govukTemplateFooter macros, which provide the <header> and <footer> element wrappers. Switch to the inner blocks (govukHeader, govukServiceNavigation, govukFooter) so the macros run as intended.
|
davidjamesstone
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency management
Removed (unused)
@hapi/catbox— not directly imported (codebase uses@hapi/catbox-memoryand@hapi/catbox-redis)@types/humanize-duration— no usage (was in production deps)atob— no import; codebase uses globalatobbuilt-in (Node.js v16+)blankie— only in stale type declarations, never registered as hapi pluginbtoa— no import; codebase uses globalbtoabuilt-in (Node.js v16+)humanize-duration— no source usagemaplibre-gl— no source usage@types/atob,@types/btoa— removed with their packages@types/eslint— no source imports from'eslint'@types/hapi,@types/hoek,@types/wreck— types for old unscoped packages not used@types/hapi__catbox-memory,@types/hapi__cookie,@types/hapi__yar— no usage@types/mysql,@types/url-parse,@types/webpack-assets-manifest— no usagecore-js— not referenced in babel config or sourceUpdated (minor/patch)
@defra/forms-model,@defra/hapi-tracing,@hapi/*,@turf/*,date-fns,dotenv,expr-eval-fork,ioredis,liquidjs,lodash,obscenity,pino-pretty,resolve,yamland all@babel/*,@types/lodash,autoprefixer,babel-loader,babel-plugin-module-resolver,cookie,globals,jest(minor within v30),nock,postcss,postcss-loader,prettier,react,react-dom,sass-embedded,terser-webpack-plugin,tsc-alias,tsx,webpack,webpack-assets-manifesttypescript-eslintpinned at 8.56.1 — v8.60.1 introduced newno-unsafe-*warnings in Joi extension callbacks (telephone.ts) that were previously passingneostandardpinned at 0.12.2 — 0.13.0 breaks eslint viaeslint-plugin-import-x(import-x drops Node.jsrequiresupport)Major updates — applied in this PR
pino: 9 → 10 — no code changes requiredeslint-plugin-jsdoc: 50 → 63 — addedreject-any-type: 'off'andreject-function-type: 'off'to both ESLint config blocks; fixed twoescape-inline-tagsviolationseslint-plugin-jest: 28 → 29 — no code changes requiredlint-staged: 15 → 17 — no code changes requiredconcurrently: 9 → 10 — no code changes required@types/node: 24 → 25 — no code changes requiredwebpack-cli: 6 → 7 — no code changes requiredcopy-webpack-plugin: 13 → 14 — no code changes requiredsass-loader: 16 → 17 — no code changes requiredcssnano+cssnano-preset-default: 7 → 8 — no code changes requiredjoi: 17 → 18 —ArraySchema<T>generic changed; addedas unknown ascasts inCheckboxesField.ts,DeclarationField.ts,FileUploadField.ts. Note:@defra/forms-model@3.0.675declarespeer joi@"^17.0.0"— functionally compatible but peer constraint will need updating upstreamgovuk-frontend: 5 → 6 — removedHeader(dropped from v6 exports); removed$govuk-new-organisation-coloursSCSS variable (became default in v6)Major updates — deferred (large)
eslintv10 —neostandard@0.12.2declarespeer eslint@"^9.0.0"; v10 incompatibleglobal-jsdomv29 /jsdomv29 /@types/jsdomv28 —@exodus/bytesESM-only nested dep causes Jest transform failurestylelintv17 /stylelint-config-gdsv3 — introduces ~128 newselector-no-qualifying-typeviolationstypescriptv6 — requiresignoreDeprecations: "6.0"and ambient type changes; deferred across all reposproxy-agentv8 — ESM-only;SyntaxError: Cannot use import statement outside a modulein Jestchokidarv5 — ESM-only; pinned at 3.6.0 to satisfy CJS transitive dep;watch requires chokidar to be installederrormarkedv16+ — ESM-only;SyntaxError: Unexpected token 'export'in Jest