Skip to content

move config to be a consumer responsibility#74

Merged
alexluckett merged 1 commit intomainfrom
feature/view-config
May 15, 2025
Merged

move config to be a consumer responsibility#74
alexluckett merged 1 commit intomainfrom
feature/view-config

Conversation

@alexluckett
Copy link
Copy Markdown
Contributor

@alexluckett alexluckett commented May 15, 2025

Proposed change

Removes the "config" from the view, instead relying on the consuming service to provide it if appropriate. Currently, we override whatever the consumer provides which breaks the forms-runner cookie banner functionality (as config.googleAnalyticsTrackingId won't exist).

Azure DevOps work item: 533186

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@alexluckett alexluckett force-pushed the feature/view-config branch from 104ac8a to adc32bf Compare May 15, 2025 15:02
@sonarqubecloud
Copy link
Copy Markdown

@alexluckett alexluckett merged commit 2cbe4e5 into main May 15, 2025
10 checks passed
@alexluckett alexluckett deleted the feature/view-config branch May 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants