-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathformAdapterEventPublisher.test.js
More file actions
254 lines (214 loc) · 7.37 KB
/
formAdapterEventPublisher.test.js
File metadata and controls
254 lines (214 loc) · 7.37 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
import { PublishCommand } from '@aws-sdk/client-sns'
import { publishFormAdapterEvent } from '~/src/server/messaging/formAdapterEventPublisher.js'
import { getSNSClient } from '~/src/server/messaging/sns.js'
/**
* @typedef {import('@defra/forms-engine-plugin/engine/types.js').FormAdapterSubmissionMessagePayload} FormAdapterSubmissionMessagePayload
*/
/**
* Helper function to test invalid payloads
* @param {unknown} invalidPayload - The invalid payload to test
* @returns {Promise<void>}
*/
async function expectValidationError(invalidPayload) {
const typedPayload = /** @type {FormAdapterSubmissionMessagePayload} */ (
invalidPayload
)
await expect(publishFormAdapterEvent(typedPayload)).rejects.toThrow(
'Invalid form adapter payload'
)
}
jest.mock('@aws-sdk/client-sns')
jest.mock('~/src/server/messaging/sns.ts')
describe('formAdapterEventPublisher', () => {
/** @type {FormAdapterSubmissionMessagePayload} */
let mockPayload
/** @type {{ send: jest.Mock }} */
let mockSnsClient
beforeEach(() => {
jest.clearAllMocks()
mockPayload = /** @type {FormAdapterSubmissionMessagePayload} */ ({
meta: {
schemaVersion: 1,
timestamp: new Date(),
formId: '507f1f77bcf86cd799439011',
formSlug: 'test-form',
formName: 'Test Form',
referenceNumber: 'REF-123456',
status: 'live',
isPreview: false,
notificationEmail: 'test@example.com'
},
data: {
main: { field1: 'value1' },
repeaters: {},
files: {}
},
result: {
files: {
main: 'main-file-path',
repeaters: {}
}
}
})
mockSnsClient = { send: jest.fn() }
jest
.mocked(getSNSClient)
.mockReturnValue(
/** @type {import('@aws-sdk/client-sns').SNSClient} */ (
/** @type {unknown} */ (mockSnsClient)
)
)
})
describe('publishFormAdapterEvent', () => {
it('successfully publishes event to SNS topic', async () => {
mockSnsClient.send.mockResolvedValue({ MessageId: 'msg-123' })
const result = await publishFormAdapterEvent(mockPayload)
expect(result).toBe('msg-123')
expect(getSNSClient).toHaveBeenCalled()
expect(PublishCommand).toHaveBeenCalledWith({
TopicArn: 'arn:aws:sns:eu-west-2:123456789012:test-adapter-topic',
Message: JSON.stringify(mockPayload)
})
expect(mockSnsClient.send).toHaveBeenCalledWith(
expect.any(PublishCommand)
)
})
it('throws error when SNS returns no MessageId', async () => {
mockSnsClient.send.mockResolvedValue({})
await expect(publishFormAdapterEvent(mockPayload)).rejects.toThrow(
'Failed to publish form adapter event - no message ID returned'
)
expect(getSNSClient).toHaveBeenCalled()
expect(mockSnsClient.send).toHaveBeenCalled()
})
it('throws error when SNS send fails', async () => {
const snsError = new Error('SNS service unavailable')
mockSnsClient.send.mockRejectedValue(snsError)
await expect(publishFormAdapterEvent(mockPayload)).rejects.toThrow(
'SNS service unavailable'
)
expect(getSNSClient).toHaveBeenCalled()
expect(mockSnsClient.send).toHaveBeenCalled()
})
it('serializes entire payload as JSON message', async () => {
mockSnsClient.send.mockResolvedValue({ MessageId: 'msg-789' })
const complexPayload =
/** @type {FormAdapterSubmissionMessagePayload} */ ({
meta: {
schemaVersion: 1,
timestamp: new Date(),
formId: '507f1f77bcf86cd799439012',
formSlug: 'complex-form',
formName: 'Complex Form',
referenceNumber: 'COMPLEX-REF',
status: 'live',
isPreview: false,
notificationEmail: 'complex@example.com'
},
data: {
main: {
nested: { inner: 'value' },
array: [1, 2, 3]
},
repeaters: {},
files: {}
},
result: {
files: {
main: 'complex-file-path',
repeaters: {}
}
}
})
await publishFormAdapterEvent(complexPayload)
expect(PublishCommand).toHaveBeenCalledWith(
expect.objectContaining({
Message: JSON.stringify(complexPayload)
})
)
})
describe('payload validation', () => {
it('validates payload successfully with valid data', async () => {
mockSnsClient.send.mockResolvedValue({ MessageId: 'msg-valid' })
const result = await publishFormAdapterEvent(mockPayload)
expect(result).toBe('msg-valid')
expect(mockSnsClient.send).toHaveBeenCalled()
})
it('throws validation error when meta is missing', async () => {
const invalidPayload = {
data: mockPayload.data,
// Intentionally omit meta property
result: mockPayload.result
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error when required meta fields are missing', async () => {
const invalidPayload = {
meta: {
schemaVersion: 1
// Missing required fields like timestamp, formId, etc.
},
data: mockPayload.data,
result: mockPayload.result
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error when data is missing', async () => {
const invalidPayload = {
meta: mockPayload.meta,
// Intentionally omit data property
result: mockPayload.result
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error when result is missing', async () => {
const invalidPayload = {
meta: mockPayload.meta,
data: mockPayload.data
// Intentionally omit result property
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error with invalid email format', async () => {
const invalidPayload = {
...mockPayload,
meta: {
...mockPayload.meta,
notificationEmail: 'invalid-email'
}
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error with invalid status', async () => {
const invalidPayload = {
...mockPayload,
meta: {
...mockPayload.meta,
status: 'invalid-status'
}
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
it('throws validation error with invalid schema version', async () => {
const invalidPayload = {
...mockPayload,
meta: {
...mockPayload.meta,
schemaVersion: 999
}
}
await expectValidationError(invalidPayload)
expect(mockSnsClient.send).not.toHaveBeenCalled()
})
})
})
})
/**
* @import { FormAdapterSubmissionMessagePayload } from '@defra/forms-engine-plugin/engine/types.js'
*/