feat/DF-623: Added payment fields but needs engine bump#23
Merged
jbarnsley10 merged 5 commits intomainfrom Feb 4, 2026
Merged
Conversation
davidjamesstone
approved these changes
Jan 27, 2026
alexluckett
reviewed
Jan 29, 2026
| */ | ||
| export function addPaymentFields(message, fields) { | ||
| const payment = /** @type {FormAdapterPayment | undefined} */ ( | ||
| Object.values(message.data.payments)[0] |
Contributor
There was a problem hiding this comment.
[0] makes me a bit nervous. Why is this neccessary?
Contributor
There was a problem hiding this comment.
Related to https://github.com/DEFRA/forms-engine-plugin/pull/293/changes#r2742602271 I am guessing we are handling multiple payments, although this isn't possible. We could simplify it and ditch data.payments altogether in favour of a single component?
|
davidjamesstone
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added payment fields as part of ticket DF-623
Needs engine bump before type checking and unit tests will pass i.e. depends on: DEFRA/forms-engine-plugin#295