feature/NI-185-nodejs-24-upgrade#119
Open
pwadmore-ea wants to merge 18 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found. |
There was a problem hiding this comment.
Pull request overview
Updates the FWIS web application to target Node.js 24, aligning local documentation, runtime container base image, dependencies, and CI/CD workflows with the upgraded Node version.
Changes:
- Bump Node.js target from 22.x to 24.x (README, package engines, CI workflow, Docker base image).
- Update several runtime/dev dependencies and refresh
package-lock.jsonaccordingly. - Extend Docker build workflow to run on additional branch types and add release-candidate tagging logic.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.md | Updates documented Node prerequisite to v24+. |
| package.json | Sets Node engine to 24.x; bumps dependencies and adds js-yaml. |
| package-lock.json | Lockfile updates reflecting the dependency and Node engine changes. |
| Dockerfile | Updates parent image tag to a Node 24 variant. |
| .github/workflows/docker.yml | Adds branch triggers, updates action pins, and introduces RC tagging metadata logic. |
| .github/workflows/ci.yml | Pins actions by SHA and updates Node setup to 24.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
28
to
31
| # Prerequisites | ||
|
|
||
| Node v22+ | ||
| Node v24+ | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/NI-185