Skip to content

AMCR-309 - Enable sonar step in other workflows#39

Open
dashkatuk wants to merge 18 commits into
mainfrom
AMCR-309-EnableSonarInPublishStep
Open

AMCR-309 - Enable sonar step in other workflows#39
dashkatuk wants to merge 18 commits into
mainfrom
AMCR-309-EnableSonarInPublishStep

AMCR-309 - Fix major sonar issue, start of critical

50413c7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 16, 2026 in 39s

Quality Gate failed

Failed conditions
32 New Critical Issues (required ≤ 0)
4 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 70 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESW9&open=AZ9fn6PQaX22YkBWESW9&pullRequest=39

Check failure on line 828 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXF&open=AZ9fn6PQaX22YkBWESXF&pullRequest=39

Check warning on line 1152 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this array "sort" operation to a separate statement or replace it with "toSorted". 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9mtbck5WRcdOwbzmgR&open=AZ9mtbck5WRcdOwbzmgR&pullRequest=39

Check warning on line 840 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 89 lines, which is greater than the 75 lines authorized. Split it into smaller functions. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXQ&open=AZ9fn6PqaX22YkBWESXQ&pullRequest=39

Check failure on line 35 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESW7&open=AZ9fn6PQaX22YkBWESW7&pullRequest=39

Check failure on line 797 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the missing "else" clause. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXP&open=AZ9fn6PqaX22YkBWESXP&pullRequest=39

Check failure on line 97 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 4 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9mtbau5WRcdOwbzmgH&open=AZ9mtbau5WRcdOwbzmgH&pullRequest=39

Check failure on line 423 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXD&open=AZ9fn6PQaX22YkBWESXD&pullRequest=39

Check failure on line 877 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXI&open=AZ9fn6PQaX22YkBWESXI&pullRequest=39

Check failure on line 108 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9mtbau5WRcdOwbzmgK&open=AZ9mtbau5WRcdOwbzmgK&pullRequest=39

Check failure on line 1176 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function has a complexity of 16 which is greater than 10 authorized. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXc&open=AZ9fn6PqaX22YkBWESXc&pullRequest=39

Check failure on line 1002 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected { after 'if' condition. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXT&open=AZ9fn6PqaX22YkBWESXT&pullRequest=39

Check warning on line 1176 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 103 lines, which is greater than the 75 lines authorized. Split it into smaller functions. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXb&open=AZ9fn6PqaX22YkBWESXb&pullRequest=39

Check failure on line 1073 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected { after 'if' condition. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXX&open=AZ9fn6PqaX22YkBWESXX&pullRequest=39

Check failure on line 980 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected { after 'if' condition. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXL&open=AZ9fn6PQaX22YkBWESXL&pullRequest=39

Check failure on line 58 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXM&open=AZ9fn6PqaX22YkBWESXM&pullRequest=39

Check failure on line 861 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXH&open=AZ9fn6PQaX22YkBWESXH&pullRequest=39

Check failure on line 844 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXG&open=AZ9fn6PQaX22YkBWESXG&pullRequest=39

Check failure on line 916 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 3 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXK&open=AZ9fn6PQaX22YkBWESXK&pullRequest=39

Check failure on line 93 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 6 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXN&open=AZ9fn6PqaX22YkBWESXN&pullRequest=39

Check failure on line 90 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 4 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9mtbau5WRcdOwbzmgG&open=AZ9mtbau5WRcdOwbzmgG&pullRequest=39

Check failure on line 1084 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected { after 'if' condition. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXY&open=AZ9fn6PqaX22YkBWESXY&pullRequest=39

Check failure on line 996 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected { after 'if' condition. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PqaX22YkBWESXS&open=AZ9fn6PqaX22YkBWESXS&pullRequest=39

Check failure on line 447 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.mock.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal 10 times. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9fn6PQaX22YkBWESXE&open=AZ9fn6PQaX22YkBWESXE&pullRequest=39

Check warning on line 1147 in src/server/routes/certificatesOfCompliance/certificates-of-compliance.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move function 'applySort' to the outer scope. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_waste-packaging-regulators-fe&issues=AZ9mtbck5WRcdOwbzmgQ&open=AZ9mtbck5WRcdOwbzmgQ&pullRequest=39
View more details on SonarQubeCloud