Replaced hardcoded values with Layout:ServiceName (#147)

* Replaced hardcoded values with Layout:ServiceName

* Corrected LSRP config phase text

* Removed the word "form" from the go to button on contributors page

Author: jack-nimbleapproach

CHANGELOG.md

@@ -62,4 +62,8 @@ All notable changes to this service will be documented in this file.
 
 ## [1.2.12]
 ### Notes
-- Added root level template property "hideFieldLabelWhenOnlyOneField" to toggle labels hiding for single field pages.
+- Added root level template property "hideFieldLabelWhenOnlyOneField" to toggle labels hiding for single field pages.
+
+- ## [1.2.13]
+### Notes
+- Replaced hardcoded values with Layout:ServiceName

src/DfE.ExternalApplications.Web/DfE.ExternalApplications.Web.csproj

@@ -5,8 +5,8 @@
 		<Nullable>enable</Nullable>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<UserSecretsId>8051c984-585b-4a5e-b6d7-833e5dd4afe7</UserSecretsId>
-		<Version>1.2.12</Version>
-		<InformationalVersion>1.2.12</InformationalVersion>
+		<Version>1.2.13</Version>
+		<InformationalVersion>1.2.13</InformationalVersion>
 		<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
 	</PropertyGroup>
 

src/DfE.ExternalApplications.Web/Pages/Applications/Contributors.cshtml

@@ -53,7 +53,7 @@
 
             <form method="post">
                 <button id="proceed-to-application-form" class="govuk-button govuk-button--secondary" type="submit" asp-page-handler="ProceedToForm" data-module="govuk-button">
-                    Go to @AppTerminology.Singular form
+                    Go to @AppTerminology.Singular
                 </button>
             </form>
         </div>

src/DfE.ExternalApplications.Web/Pages/Feedback/General.cshtml

@@ -1,8 +1,10 @@
 @page "/Feedback/General"
 @using GovUK.Dfe.CoreLibs.Contracts.ExternalApplications.Models.Request
 @model DfE.ExternalApplications.Web.Pages.Feedback.GeneralModel
+@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
 @{
-	ViewData["Title"] = "Give feedback on the Apply to transfer an academy into your trust service";
+	var serviceName = Configuration["Layout:ServiceName"] ?? "External Applications";
+	ViewData["Title"] = $"Give feedback on the {serviceName} service";
 }
 
 @section BeforeContent {
@@ -19,7 +21,7 @@
 <div class="govuk-grid-row">
 	<div class="govuk-grid-column-two-thirds">
 		<h1 class="govuk-heading-l">
-			Give feedback on the Apply to transfer an academy into your trust service
+			Give feedback on the @serviceName service
 		</h1>
 
 		<form method="post">

src/DfE.ExternalApplications.Web/Pages/Shared/Cookies.cshtml

@@ -1,14 +1,16 @@
-@page "/Cookies"
+@page "/Cookies"
 @using GovUk.Frontend.AspNetCore
 @using Microsoft.AspNetCore.Http.Features;
 @using Microsoft.AspNetCore.Http;
 @model DfE.ExternalApplications.Web.Pages.Shared.CookiesModel;
+@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
 
 @{
     ViewData["Title"] = "Cookies";
 
     var consentFeature = this.HttpContext.Features.Get<ITrackingConsentFeature>();
     var canTrack = consentFeature?.CanTrack ?? false;
+    var serviceName = Configuration["Layout:ServiceName"] ?? "External Applications";
 }
 
 @{
@@ -37,7 +39,7 @@
         <p class="govuk-body">Cookies are small files saved on your phone, tablet or computer when you visit a website.</p>
         <p class="govuk-body">We use cookies to make this service work and collect information about how you use our service.</p>
         <h2 class="govuk-heading-m">Essential cookies</h2>
-        <p class="govuk-body">Essential cookies keep your information secure while you use Apply to transfer an academy into your trust. We do not need to ask permission to use them.</p>
+        <p class="govuk-body">Essential cookies keep your information secure while you use @serviceName. We do not need to ask permission to use them.</p>
         <table class="govuk-table">
             <thead class="govuk-table__head">
                 <tr class="govuk-table__row">

src/DfE.ExternalApplications.Web/Pages/Shared/PrivacyNotice.cshtml

@@ -1,10 +1,14 @@
-@page "/Privacy"
+@page "/Privacy"
+@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
+@{
+    var serviceName = Configuration["Layout:ServiceName"] ?? "External Applications";
+}
 
 <div class="govuk-grid-row">
             <div class="govuk-grid-column-two-thirds">
-        <h1 class="govuk-heading-xl">Privacy notice for the Apply to transfer an academy into your trust service</h1>
+        <h1 class="govuk-heading-xl">Privacy notice for the @serviceName service</h1>
         <p class="govuk-body">
-            The Department for Education (DfE) owns the Apply to transfer an academy into your trust service and is the <a href="https://ico.org.uk/for-organisations/guide-to-data-protection/guide-to-the-general-data-protection-regulation-gdpr/controllers-and-processors/what-are-controllers-and-processors/">data controller (opens in new tab)</a> for it.
+            The Department for Education (DfE) owns the @serviceName service and is the <a href="https://ico.org.uk/for-organisations/guide-to-data-protection/guide-to-the-general-data-protection-regulation-gdpr/controllers-and-processors/what-are-controllers-and-processors/">data controller (opens in new tab)</a> for it.
         </p>
         <p class="govuk-body">
             For detailed information on how we handle personal data, including your rights and our responsibilities, see our department’s privacy notice - <a href="https://www.gov.uk/government/publications/privacy-information-education-providers-workforce-including-teachers/privacy-information-education-providers-workforce-including-teachers#using-your-data-when-you-usedfesign-in">Privacy information: education providers’ workforce, including teachers</a>. This document includes the principles and practices we follow to make sure your information is processed securely as required by applicable data protection laws.

src/DfE.ExternalApplications.Web/Pages/Shared/TermsAndConditions.cshtml

@@ -1,10 +1,14 @@
-@page "/Terms"
+@page "/Terms"
+@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
+@{
+    var serviceName = Configuration["Layout:ServiceName"] ?? "External Applications";
+}
 <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds">
         <h1 class="govuk-heading-xl">Terms and Conditions</h1>
 
         <h2 class="govuk-heading-l">All Users</h2>
-        <h3 class="govuk-heading-m">Using the Apply to transfer an academy into your trust service</h3>
+        <h3 class="govuk-heading-m">Using the @serviceName service</h3>
         <p class="govuk-body">
         Please read these Terms of Use (“General Terms”) carefully before using this service (the “Service”).
         </p>

src/DfE.ExternalApplications.Web/Pages/Shared/_CookiesBanner.cshtml

@@ -1,11 +1,13 @@
-@using Microsoft.AspNetCore.Http.Features
+@using Microsoft.AspNetCore.Http.Features
+@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
 
 @{
+    var serviceName = Configuration["Layout:ServiceName"] ?? "External Applications";
     var consentFeature = Context.Features.Get<ITrackingConsentFeature>();
 
     var showBanner = !(consentFeature?.CanTrack ?? false) && Context.Session.GetInt32("cookiesRejected") != 1;
     var returnPath = Context.Request.Path;
-    var label = "Cookies on Apply to transfer an academy into your trust";
+    var label = $"Cookies on {serviceName}";
 }
 
 @if (showBanner)

src/DfE.ExternalApplications.Web/configurations/Lsrp/appsettings.json

@@ -122,7 +122,7 @@
   "Layout": {
     "ServiceName": "Local SEND Reform Plans",
     "PhaseBanner": {
-      "PhaseText": "Beta",
+      "PhaseText": "Alpha",
       "FeedbackLink": "/Feedback"
     }
   },