move rake task logic into a service

Author: alkesh

app/services/course_cohort_providers/updater.rb

@@ -0,0 +1,30 @@
+module CourseCohortProviders
+  class Updater
+    def initialize(cohort:, course_to_provider_csv:, dry_run:, logger: Rails.logger)
+      @cohort = cohort
+      @course_to_provider_csv = course_to_provider_csv
+      @dry_run = dry_run
+      @logger = logger
+    end
+
+    attr_reader :cohort, :course_to_provider_csv, :dry_run, :logger
+
+    def call
+      CourseCohort.transaction do
+        logger.info "Dry Run" if dry_run
+
+        CSV.foreach(course_to_provider_csv, headers: true, header_converters: :symbol, strip: true) do |row|
+          course = Course.find_by!(identifier: row[:course_identifier])
+          course_cohort = CourseCohort.find_or_create_by!(course:, cohort:)
+          lead_provider = LeadProvider.find_by!(name: row[:lead_provider_name])
+          course_cohort.course_cohort_providers.find_or_create_by!(lead_provider:)
+        end
+
+        if dry_run
+          logger.info "Dry run: rolling back"
+          raise ActiveRecord::Rollback
+        end
+      end
+    end
+  end
+end

lib/tasks/course_cohort_providers.rake

@@ -5,26 +5,12 @@ namespace :course_cohort_providers do
 
     logger = Rails.env.test? ? Rails.logger : Logger.new($stdout)
 
-    logger.info "Dry Run" if dry_run
-
     raise "Missing required argument: cohort_identifier" unless args.cohort_identifier
 
     cohort = Cohort.find_by(identifier: args.cohort_identifier)
     raise "Cohort not found with identifier: #{args.cohort_identifier}" unless cohort
     raise "Missing required argument: course_to_provider_csv" unless args.course_to_provider_csv
 
-    CourseCohort.transaction do
-      CSV.foreach(args[:course_to_provider_csv], headers: true, header_converters: :symbol, strip: true) do |row|
-        course = Course.find_by!(identifier: row[:course_identifier])
-        course_cohort = CourseCohort.find_or_create_by!(course:, cohort:)
-        lead_provider = LeadProvider.find_by!(name: row[:lead_provider_name])
-        course_cohort.course_cohort_providers.find_or_create_by!(lead_provider:)
-      end
-
-      if dry_run
-        logger.info "Dry run: rolling back"
-        raise ActiveRecord::Rollback
-      end
-    end
+    CourseCohortProviders::Updater.new(cohort:, course_to_provider_csv: args.course_to_provider_csv, dry_run:, logger:).call
   end
 end

spec/lib/tasks/course_cohort_providers_spec.rb

@@ -9,6 +9,7 @@
     let(:cohort_identifier) { cohort.identifier }
     let(:headship_course) { create(:course, :headship) }
     let(:csv_file_path) { csv_file.path }
+    let(:updater) { instance_double(CourseCohortProviders::Updater, call: nil) }
 
     let(:csv_file) do
       tempfile <<~CSV
@@ -21,6 +22,7 @@
     before do
       cohort
       headship_course
+      allow(CourseCohortProviders::Updater).to receive(:new).and_return(updater)
     end
 
     after do
@@ -54,32 +56,28 @@
     context "when dry run is false" do
       let(:dry_run) { "false" }
 
-      it "creates course cohorts" do
-        run_task
-        expect(cohort.course_cohorts.pluck(:course_id)).to contain_exactly(headship_course.id)
-      end
-
-      it "creates course cohort providers" do
-        run_task
-        course_cohort = cohort.course_cohorts.find_by(course: headship_course)
-        expect(headship_course.course_cohort_providers.where(course_cohort:).pluck(:lead_provider_id)).to(
-          contain_exactly(
-            LeadProvider.find_by(name: "Ambition Institute").id,
-            LeadProvider.find_by(name: "Best Practice Network").id,
-          ),
+      it "calls the updater" do
+        expect(CourseCohortProviders::Updater).to receive(:new).with(
+          cohort:,
+          course_to_provider_csv: csv_file_path,
+          dry_run: false,
+          logger: Rails.logger,
         )
+        expect(updater).to receive(:call)
+        run_task
       end
     end
 
     context "when dry run is true" do
-      it "does not create course cohorts" do
-        run_task
-        expect(CourseCohort.count).to eq 0
-      end
-
-      it "does not create course cohort providers" do
+      it "calls the updater" do
+        expect(CourseCohortProviders::Updater).to receive(:new).with(
+          cohort:,
+          course_to_provider_csv: csv_file_path,
+          dry_run: true,
+          logger: Rails.logger,
+        )
+        expect(updater).to receive(:call)
         run_task
-        expect(CourseCohortProvider.count).to eq 0
       end
     end
   end

spec/services/course_cohort_providers/updater_spec.rb

@@ -0,0 +1,58 @@
+require "rails_helper"
+
+RSpec.describe CourseCohortProviders::Updater do
+  let(:cohort) { create(:cohort, :current) }
+  let(:headship_course) { create(:course, :headship) }
+  let(:csv_file_path) { csv_file.path }
+
+  let(:csv_file) do
+    tempfile <<~CSV
+      course_identifier, lead_provider_name
+      npq-headship, Ambition Institute
+      npq-headship, Best Practice Network
+    CSV
+  end
+
+  before do
+    cohort
+    headship_course
+  end
+
+  describe ".call" do
+    subject { described_class.new(cohort:, course_to_provider_csv: csv_file_path, dry_run:).call }
+
+    context "when dry run is false" do
+      let(:dry_run) { false }
+
+      it "creates course cohorts" do
+        subject
+        expect(cohort.course_cohorts.pluck(:course_id)).to contain_exactly(headship_course.id)
+      end
+
+      it "creates course cohort providers" do
+        subject
+        course_cohort = cohort.course_cohorts.find_by(course: headship_course)
+        expect(headship_course.course_cohort_providers.where(course_cohort:).pluck(:lead_provider_id)).to(
+          contain_exactly(
+            LeadProvider.find_by(name: "Ambition Institute").id,
+            LeadProvider.find_by(name: "Best Practice Network").id,
+          ),
+        )
+      end
+    end
+
+    context "when dry run is true" do
+      let(:dry_run) { true }
+
+      it "does not create course cohorts" do
+        subject
+        expect(CourseCohort.count).to eq 0
+      end
+
+      it "does not create course cohort providers" do
+        subject
+        expect(CourseCohortProvider.count).to eq 0
+      end
+    end
+  end
+end