[BAU] Check feature flag before sending custom version events#3061
Open
jebw wants to merge 1 commit into
Open
Conversation
jebw
commented
Nov 27, 2025
| queue_as :low_priority | ||
|
|
||
| def perform(user_name, data) | ||
| return unless dfe_analytics_enabled? |
Collaborator
Author
There was a problem hiding this comment.
I've done this check within the Job but I can see an argument for doing it in the module and never creating the job? Thoughts
Contributor
There was a problem hiding this comment.
yeah - may be better done in the module:
base.after_commit :send_to_dfe_analytics, on: :create, if: -> { Feature.dfe_analytics_enabled? }
|
Contributor
|
Review app deployed to https://npq-registration-review-3061-web.test.teacherservices.cloud/ |
jebw
force-pushed
the
bau-version-custom-events-honour-feature-flag
branch
from
bc40196 to
66bc849
Compare
|
alkesh
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Ticket: BAU
Currently we're trying to send custom events when versions are created even if the feature flag is off for dfe analytics
Changes proposed in this pull request