[NPQ-3687] Initial minimal wizard#3312
Open
jebw wants to merge 1 commit into
Open
Conversation
Contributor
|
Review app deployed to https://npq-registration-review-3312-web.test.teacherservices.cloud/ |
alkesh
reviewed
May 6, 2026
| end | ||
|
|
||
| require "capybara-screenshot/rspec" | ||
| require "capybara-screenshot/rspec" unless ENV["NO_CAPYBARA_SCREENSHOTS"] == "true" |
Contributor
There was a problem hiding this comment.
might be worth documenting this env var in docs/specs_and_linting.md
| [] | ||
| end | ||
|
|
||
| def to_s = self.class.model_name.element |
Contributor
There was a problem hiding this comment.
Suggested change
| def to_s = self.class.model_name.element | |
| def to_s = self.class.model_name.element | |
is it worth having a blank line separating these methods? I'm not hugely fussed either way really.
Contributor
|
Review app for PR 3312 was deleted |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Ticket: NPQ-3687
Whilst our existing wizard works fairly well, we have various oddities
Changes proposed in this pull request
Note: I've tried to strip out anything extraneous or untestable from this initial set of changes but I know the routing logic for check_answers is in there. This isn't really testable till later steps are added so when I'll add specs for that in the follow up PRs
Note 2: The SonarScanner warnings on the
requirelines are technnically correct but this is a conscious choice to not load dependencies until actually required as part of visualisation generationNote 3: I need to add an ADR, will do that an revise PR