Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Content revisions following review#837

Merged
andrewscrivener merged 1 commit into
mainfrom
integrate-census-sign-off
Jun 4, 2025
Merged

Content revisions following review#837
andrewscrivener merged 1 commit into
mainfrom
integrate-census-sign-off

Conversation

@andrewscrivener
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Andrew Scrivener <andrew.scrivener@education.gov.uk>
@andrewscrivener andrewscrivener requested a review from Copilot June 4, 2025 14:35
@carlosmartinez carlosmartinez temporarily deployed to register-tt-pr-837 June 4, 2025 14:35 Inactive
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates content and templates to reflect the upcoming academic year and revise the census export/sign-off flow.

  • Introduce nextAcademicYear and update link text, headings, and paragraphs across views.
  • Revise export and sign-off copy to align with the next ITT census date.
  • Clean up unused markup and adjust heading levels for the export page.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
app/views/reports/index.njk Added nextAcademicYear and updated the “Census sign off” link to reference the next year.
app/views/census-sign-off/index.njk Overhauled page heading, explanatory text, list items, and export link for the next year.
app/views/census-sign-off/form.njk Updated the form heading to use nextAcademicYear and capitalized the page heading.
app/views/census-sign-off/confirmation.njk Removed extraneous whitespace.
Comments suppressed due to low confidence (3)

app/views/reports/index.njk:25

  • [nitpick] The link text is a bit unclear and grammatically awkward. Consider rephrasing to something like “Report trainees who started in {{ nextAcademicYear }} – census sign-off for the {{ nextAcademicYear }} academic year” for readability.
<p class="govuk-body"><a class="govuk-link" href="/census-sign-off/">Trainees with their academic start year in {{ nextAcademicYear }} report</a> – census sign off your new trainee data for the {{ nextAcademicYear }} academic year</p>

app/views/census-sign-off/form.njk:8

  • [nitpick] The nextAcademicYearShort variable is set but not used in this template. Consider removing it or using it in the copy to keep the code clean.
{% set nextAcademicYearShort = data.years.nextAcademicYear | academicYearToYear %}

app/views/census-sign-off/index.njk:63

  • This export link uses a placeholder href="#". It should point to the actual CSV download endpoint or revert to the govukButton component to trigger the export action properly.
<p class="govuk-body"><a class="govuk-link" href="#">Export {{ nextAcademicYear }} trainee data (82 trainees)</a>.</p>

@andrewscrivener andrewscrivener merged commit 6c94114 into main Jun 4, 2025
1 of 2 checks passed
@andrewscrivener andrewscrivener deleted the integrate-census-sign-off branch June 4, 2025 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants