This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Content revisions following review#837
Merged
Merged
Conversation
Signed-off-by: Andrew Scrivener <andrew.scrivener@education.gov.uk>
There was a problem hiding this comment.
Pull Request Overview
This PR updates content and templates to reflect the upcoming academic year and revise the census export/sign-off flow.
- Introduce
nextAcademicYearand update link text, headings, and paragraphs across views. - Revise export and sign-off copy to align with the next ITT census date.
- Clean up unused markup and adjust heading levels for the export page.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/views/reports/index.njk | Added nextAcademicYear and updated the “Census sign off” link to reference the next year. |
| app/views/census-sign-off/index.njk | Overhauled page heading, explanatory text, list items, and export link for the next year. |
| app/views/census-sign-off/form.njk | Updated the form heading to use nextAcademicYear and capitalized the page heading. |
| app/views/census-sign-off/confirmation.njk | Removed extraneous whitespace. |
Comments suppressed due to low confidence (3)
app/views/reports/index.njk:25
- [nitpick] The link text is a bit unclear and grammatically awkward. Consider rephrasing to something like “Report trainees who started in {{ nextAcademicYear }} – census sign-off for the {{ nextAcademicYear }} academic year” for readability.
<p class="govuk-body"><a class="govuk-link" href="/census-sign-off/">Trainees with their academic start year in {{ nextAcademicYear }} report</a> – census sign off your new trainee data for the {{ nextAcademicYear }} academic year</p>
app/views/census-sign-off/form.njk:8
- [nitpick] The
nextAcademicYearShortvariable is set but not used in this template. Consider removing it or using it in the copy to keep the code clean.
{% set nextAcademicYearShort = data.years.nextAcademicYear | academicYearToYear %}
app/views/census-sign-off/index.njk:63
- This export link uses a placeholder
href="#". It should point to the actual CSV download endpoint or revert to thegovukButtoncomponent to trigger the export action properly.
<p class="govuk-body"><a class="govuk-link" href="#">Export {{ nextAcademicYear }} trainee data (82 trainees)</a>.</p>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.