[0544] Session fixation session id not rotated after OIDC authentication completes#540
Merged
defong merged 3 commits intoJul 9, 2026
Conversation
defong
force-pushed
the
544-session-fixation-session-id-not-rotated-after-oidc-authentication-completes
branch
from
July 7, 2026 13:31
b38da1b to
c3a8a71
Compare
Collaborator
Author
kennyevil
approved these changes
Jul 8, 2026
defong
deleted the
544-session-fixation-session-id-not-rotated-after-oidc-authentication-completes
branch
July 9, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Session fixation
Changes proposed in this pull request
Fixed fixation issue
Fixed requested path issue
Fixed unclean sign out issue
Guidance to review
The stress free way is to remove the changes in sessions controller and see the tests fails and watch it pass after it has been added back in.