Amended to move any associated one login user to retained person during merge (#2969)

### Context

https://trello.com/c/14ZB8ztv/2182-update-merge-records-journey-with-one-login-considerations

Author: hortha

TeachingRecordSystem/src/TeachingRecordSystem.Core/Models/OneLoginUserMatchRoute.cs

@@ -5,7 +5,7 @@ public enum OneLoginUserMatchRoute
     Automatic = 1,
     Interactive = 2,
     TrnToken = 3,
-    Support = 4,
+    SupportUi = 4,
     GetAnIdentityUser = 5,
     TrnRequest = 6
 }

TeachingRecordSystem/src/TeachingRecordSystem.Core/Services/Persons/PersonService.cs

@@ -328,6 +328,21 @@ public async Task MergePersonsAsync(MergePersonsOptions options, ProcessContext
         deactivatingPerson.MergedWithPersonId = options.RetainedPersonId;
         deactivatingPerson.UpdatedOn = now;
 
+        // If the deactivated person was associated with a One Login User, transfer that association to the retained person
+        var oneLoginUser = await dbContext.OneLoginUsers
+            .SingleOrDefaultAsync(u => u.PersonId == deactivatingPerson.PersonId);
+
+        if (oneLoginUser is not null)
+        {
+            oneLoginUser.SetMatched(
+                now,
+                retainedPerson.PersonId,
+                OneLoginUserMatchRoute.SupportUi,
+                matchedAttributes: null);
+
+            // Events to be added in follow up work
+        }
+
         await dbContext.SaveChangesAsync();
 
         await eventPublisher.PublishEventAsync(

TeachingRecordSystem/src/TeachingRecordSystem.Core/Services/SupportTasks/OneLoginUserIdVerification/OneLoginUserIdVerificationSupportTaskService.cs

@@ -125,7 +125,7 @@ await oneLoginService.SetUserMatchedAsync(
             {
                 OneLoginUserSubject = supportTask.OneLoginUserSubject!,
                 MatchedPersonId = options.MatchedPersonId,
-                MatchRoute = OneLoginUserMatchRoute.Support,
+                MatchRoute = OneLoginUserMatchRoute.SupportUi,
                 MatchedAttributes = options.MatchedAttributes
             },
             processContext);

TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/SupportTasks/ConnectOneLoginUser/Connect.cshtml.cs

@@ -44,7 +44,7 @@ public async Task<IActionResult> OnPostAsync()
         oneLoginUser.SetMatched(
             clock.UtcNow,
             PersonDetail!.PersonId,
-            OneLoginUserMatchRoute.Support,
+            OneLoginUserMatchRoute.SupportUi,
             matchedAttributes);
 
         await dbContext.SaveChangesAsync();

TeachingRecordSystem/tests/TeachingRecordSystem.Core.Tests/Services/OneLogin/OneLoginServiceTests.cs

@@ -79,7 +79,7 @@ public async Task SetUserMatchedAsync_UserIsNotVerified_ThrowsInvalidOperationEx
         {
             OneLoginUserSubject = oneLoginUser.Subject,
             MatchedPersonId = Guid.NewGuid(),
-            MatchRoute = OneLoginUserMatchRoute.Support,
+            MatchRoute = OneLoginUserMatchRoute.SupportUi,
             MatchedAttributes = []
         };
 
@@ -103,7 +103,7 @@ public async Task SetUserMatchedAsync_SetsMatchedPropertiesOnUser()
         {
             OneLoginUserSubject = oneLoginUser.Subject,
             MatchedPersonId = matchedPerson.PersonId,
-            MatchRoute = OneLoginUserMatchRoute.Support,
+            MatchRoute = OneLoginUserMatchRoute.SupportUi,
             MatchedAttributes = [
                 KeyValuePair.Create(PersonMatchedAttribute.FirstName, matchedPerson.FirstName),
                 KeyValuePair.Create(PersonMatchedAttribute.LastName, matchedPerson.LastName)

TeachingRecordSystem/tests/TeachingRecordSystem.Core.Tests/Services/Persons/PersonServiceTests.cs

@@ -1103,6 +1103,46 @@ await WithDbContextAsync(async dbContext =>
         });
     }
 
+    [Fact]
+    public async Task MergePersonsAsync_PersonToDeactivateIsAssociatedWithOneLoginUser_AssociatesThatOneLoginUserWithRetainedPerson()
+    {
+        // Arrange
+        var personToRetain = await TestData.CreatePersonAsync();
+        var personToDeactivate = await TestData.CreatePersonAsync();
+        var oneLoginUser = await TestData.CreateOneLoginUserAsync(
+            personId: personToDeactivate.PersonId,
+            verifiedInfo: ([personToDeactivate.FirstName, personToDeactivate.LastName], personToDeactivate.DateOfBirth));
+        var evidenceFileId = Guid.NewGuid();
+        var evidenceFileName = "evidence.jpg";
+        var comments = Faker.Lorem.Paragraph();
+
+        var options = new MergePersonsOptions(
+            personToDeactivate.PersonId,
+            personToRetain.PersonId,
+            personToRetain.Person.Details,
+            new()
+            {
+                FileId = evidenceFileId,
+                Name = evidenceFileName
+            },
+            comments);
+
+        var processContext = new ProcessContext(ProcessType.PersonMerging, Clock.UtcNow, SystemUser.SystemUserId);
+
+        // Act
+        await WithServiceAsync(s => s.MergePersonsAsync(options, processContext));
+
+        // Assert
+        await WithDbContextAsync(async dbContext =>
+        {
+            var updatedOneLoginUser = await dbContext.OneLoginUsers
+                .SingleAsync(o => o.Subject == oneLoginUser.Subject);
+            Assert.Equal(personToRetain.PersonId, updatedOneLoginUser.PersonId);
+            Assert.Equal(Clock.UtcNow, updatedOneLoginUser.MatchedOn);
+            Assert.Equal(OneLoginUserMatchRoute.SupportUi, updatedOneLoginUser.MatchRoute);
+        });
+    }
+
     private Task WithServiceAsync(Func<PersonService, Task> action, params object[] arguments) =>
         WithServiceAsync<PersonService>(action, arguments);
 

TeachingRecordSystem/tests/TeachingRecordSystem.Core.Tests/Services/SupportTasks/OneLoginUserIdVerification/OneLoginUserIdVerificationSupportTaskServiceTests.cs

@@ -209,7 +209,7 @@ public async Task ResolveSupportTaskAsync_WithVerifiedAndConnectedOutcome_Closes
         Assert.Collection(updatedOneLoginUser.VerifiedDatesOfBirth, dob => Assert.Equal(data.StatedDateOfBirth, dob));
         Assert.Equal(matchedPerson.PersonId, updatedOneLoginUser.PersonId);
         Assert.Equal(Clock.UtcNow, updatedOneLoginUser.MatchedOn);
-        Assert.Equal(OneLoginUserMatchRoute.Support, updatedOneLoginUser.MatchRoute);
+        Assert.Equal(OneLoginUserMatchRoute.SupportUi, updatedOneLoginUser.MatchRoute);
         Assert.NotNull(updatedOneLoginUser.MatchedAttributes);
 
         await BackgroundJobScheduler.ExecuteDeferredJobsAsync();

TeachingRecordSystem/tests/TeachingRecordSystem.SupportUi.Tests/PageTests/SupportTasks/ConnectOneLoginUser/ConnectTests.cs

@@ -162,7 +162,7 @@ await WithDbContextAsync(async dbContext =>
 
             oneLoginUser = await dbContext.OneLoginUsers.SingleAsync(u => u.Subject == oneLoginUser.Subject);
             Assert.Equal(person.PersonId, oneLoginUser.PersonId);
-            Assert.Equal(OneLoginUserMatchRoute.Support, oneLoginUser.MatchRoute);
+            Assert.Equal(OneLoginUserMatchRoute.SupportUi, oneLoginUser.MatchRoute);
             Assert.NotEmpty(oneLoginUser.MatchedAttributes!);
         });
     }