Update flow to delete entire reference rather than just the file

Author: KyleMacPherson

app/controllers/publishers/vacancies/job_applications/reference_requests_controller.rb

@@ -49,12 +49,6 @@ def mark_as_complete
           redirect_to organisation_job_job_application_reference_request_path(@vacancy.id, @job_application.id, @reference_request.id)
         end
 
-        def reference_form
-          @reference_request.reference_form.purge_later
-          redirect_to organisation_job_job_application_reference_request_path(@vacancy.id, @job_application.id, @reference_request.id),
-                      success: t(".success")
-        end
-
         private
 
         def email_form_class

app/controllers/publishers/vacancies/job_applications/references_controller.rb

@@ -11,6 +11,12 @@ def new
           @referee = RefereeForm.new
         end
 
+        def destroy
+          @job_application.referees.find(params[:id]).destroy
+          redirect_to pre_interview_checks_organisation_job_job_application_path(@vacancy.id, @job_application),
+                      success: t(".success")
+        end
+
         def create
           @note = @job_application.notes.build
           @referee = RefereeForm.new(referee_form_params)

app/views/publishers/vacancies/job_applications/reference_requests/show.html.slim

@@ -50,12 +50,14 @@
         = summary_list.with_row do |row|
           - row.with_key(text: key)
           - row.with_value(text: value)
+      - if @reference_request.reference_form.attached?
+        = summary_list.with_row do |row|
+          - row.with_key(text: t(".uploaded_reference.heading"))
+          - row.with_value do
+            = govuk_link_to "#{@reference_request.reference_form.filename} (#{number_to_human_size(@reference_request.reference_form.byte_size)})", @reference_request.reference_form
 
     - if @reference_request.reference_form.attached?
-      h2.govuk-heading-m = t(".uploaded_reference.heading")
-      p.govuk-body
-        = govuk_link_to "#{@reference_request.reference_form.filename} (#{number_to_human_size(@reference_request.reference_form.byte_size)})", @reference_request.reference_form
-      = govuk_link_to t(".uploaded_reference.delete"), reference_form_organisation_job_job_application_reference_request_path(@vacancy.id, @job_application.id, @reference_request.id), method: :delete, class: "govuk-link govuk-link--no-visited-state"
+      = govuk_button_link_to t(".uploaded_reference.delete"), organisation_job_job_application_reference_path(@vacancy.id, @job_application.id, @reference_request.referee), method: :delete, class: "govuk-button--warning"
 
     - if @reference_request.sent?
       - if @job_reference.complete?

config/locales/publishers/vacancies/job_applications.en.yml

@@ -13,6 +13,8 @@ en:
     vacancies:
       job_applications:
         references:
+          destroy:
+            success: Reference deleted successfully
           new:
             page_title: Create reference
             caption: Reference
@@ -165,12 +167,10 @@ en:
           edit:
             caption: Update referee information
             heading: What is the correct email address for %{name}?
-          reference_form:
-            success: Reference document deleted successfully
           show:
             uploaded_reference:
               heading: Uploaded reference
-              delete: Delete uploaded reference
+              delete: Delete reference
             print: Download reference
             how_would_you_rate: How would you rate %{name}?
             page_title: Reference

config/routes.rb

@@ -449,7 +449,6 @@
             patch :mark_as_received
             patch :mark_as_complete
             patch :send_reminder_email
-            delete :reference_form
           end
         end
         get :download
@@ -462,7 +461,7 @@
           get :pre_employment_checks
         end
         resource :religious_reference, only: %i[edit update], controller: "publishers/vacancies/job_applications/religious_references"
-        resources :references, only: %i[new create], controller: "publishers/vacancies/job_applications/references"
+        resources :references, only: %i[new create destroy], controller: "publishers/vacancies/job_applications/references"
         resource :online_checks, only: %i[edit update], controller: "publishers/vacancies/job_applications/online_checks"
         resource :pre_employment_check_set, only: %i[update], controller: "publishers/vacancies/job_applications/pre_employment_checks"
         member do

spec/requests/publishers/vacancies/job_applications/reference_requests_spec.rb

@@ -20,25 +20,6 @@
 
   after { sign_out(publisher) }
 
-  describe "DELETE #reference_form" do
-    context "when a reference form is attached" do
-      before do
-        reference_request.reference_form.attach(
-          io: Rails.root.join("spec/fixtures/files/blank_job_spec.pdf").open,
-          filename: "reference.pdf",
-          content_type: "application/pdf",
-        )
-      end
-
-      it "purges the reference form and redirects to the show page" do
-        delete reference_form_organisation_job_job_application_reference_request_path(vacancy.id, job_application.id, reference_request.id)
-
-        expect(reference_request.reload.reference_form).not_to be_attached
-        expect(response).to redirect_to(organisation_job_job_application_reference_request_path(vacancy.id, job_application.id, reference_request.id))
-      end
-    end
-  end
-
   describe "GET #show" do
     context "when request format is pdf" do
       it "returns the pdf file" do

spec/requests/publishers/vacancies/job_applications/references_spec.rb

@@ -0,0 +1,27 @@
+require "rails_helper"
+
+RSpec.describe "Job applications references" do
+  let(:vacancy) { create(:vacancy) }
+  let(:organisation) { vacancy.organisations.first }
+  let(:job_application) { create(:job_application, :status_submitted, vacancy:) }
+  let(:referee) { create(:referee, job_application:) }
+  let(:publisher) { create(:publisher, accepted_terms_at: 1.day.ago) }
+
+  before do
+    # rubocop:disable RSpec/AnyInstance
+    allow_any_instance_of(ApplicationController).to receive(:current_organisation).and_return(organisation)
+    # rubocop:enable RSpec/AnyInstance
+    sign_in(publisher, scope: :publisher)
+  end
+
+  after { sign_out(publisher) }
+
+  describe "DELETE #destroy" do
+    it "destroys the referee and redirects to pre-interview checks" do
+      delete organisation_job_job_application_reference_path(vacancy.id, job_application.id, referee.id)
+
+      expect { referee.reload }.to raise_error(ActiveRecord::RecordNotFound)
+      expect(response).to redirect_to(pre_interview_checks_organisation_job_job_application_path(vacancy.id, job_application.id))
+    end
+  end
+end

spec/system/publishers/publishers_can_add_a_manual_reference_spec.rb

@@ -78,10 +78,10 @@
       expect(page).to have_content("Uploaded reference")
       expect(page).to have_content("blank_job_spec.pdf")
 
-      click_on "Delete uploaded reference"
-      expect(page).to have_content("Reference document deleted successfully")
-      expect(page).to have_no_content("Uploaded reference")
-      expect(ReferenceRequest.last.reference_form.attached?).to be false
+      click_on "Delete reference"
+      expect(page).to have_current_path(pre_interview_checks_organisation_job_job_application_path(vacancy.id, job_application.id))
+      expect(page).to have_content("Reference deleted successfully")
+      expect(page).to have_no_content(referee_name)
     end
   end
 end