Professional membership migration (#8736)

Author: starswan

.database_consistency.yml

@@ -102,9 +102,3 @@ ProfileEmployment:
   jobseeker_profile:
     ColumnPresenceChecker:
       enabled: false
-
-# This now no longer points at 2 tables, but we can't remove the column yet
-ProfessionalBodyMembership:
-  job_application:
-    ColumnPresenceChecker:
-      enabled: false

config/analytics.yml

@@ -587,7 +587,6 @@ shared:
     - membership_number
     - year_membership_obtained
     - exam_taken
-    - jobseeker_profile_id
     - job_application_id
   :self_disclosure_requests:
     - id

db/migrate/20260330105614_professional_membership_job_application.rb

@@ -0,0 +1,16 @@
+class ProfessionalMembershipJobApplication < ActiveRecord::Migration[8.0]
+  disable_ddl_transaction!
+
+  def change
+    remove_index :professional_body_memberships, :jobseeker_profile_id, algorithm: :concurrently
+    safety_assured { remove_column :professional_body_memberships, :jobseeker_profile_id, :uuid }
+
+    add_not_null_constraint :professional_body_memberships, :job_application_id, name: "professional_body_memberships_job_application_id_null", validate: false
+    # You can use `validate_constraint_in_background` if you have a very large table
+    # and want to validate the constraint using background schema migrations.
+    validate_not_null_constraint :professional_body_memberships, :job_application_id, name: "professional_body_memberships_job_application_id_null"
+
+    change_column_null :professional_body_memberships, :job_application_id, false
+    remove_check_constraint :professional_body_memberships, name: "professional_body_memberships_job_application_id_null"
+  end
+end

db/schema.rb

@@ -620,10 +620,8 @@
     t.string "membership_number"
     t.integer "year_membership_obtained"
     t.boolean "exam_taken", default: false, null: false
-    t.uuid "jobseeker_profile_id"
-    t.uuid "job_application_id"
+    t.uuid "job_application_id", null: false
     t.index ["job_application_id"], name: "index_professional_body_memberships_on_job_application_id"
-    t.index ["jobseeker_profile_id"], name: "index_professional_body_memberships_on_jobseeker_profile_id"
   end
 
   create_table "publisher_ats_api_clients", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
@@ -1027,7 +1025,6 @@
   add_foreign_key "personal_details", "jobseeker_profiles"
   add_foreign_key "pre_employment_check_sets", "job_applications"
   add_foreign_key "professional_body_memberships", "job_applications"
-  add_foreign_key "professional_body_memberships", "jobseeker_profiles"
   add_foreign_key "publisher_preferences", "organisations"
   add_foreign_key "publisher_preferences", "publishers"
   add_foreign_key "qualification_results", "qualifications"