Fix OOM in search-sync + schedule daily cron (#313)

* schedule sync-device-definitions-search daily, remove deprecated r1 CLI

Replaces the r1-search-gsheet-sync cron entry with device-definitions-search-sync
(daily 13:00 UTC) and drops the sync-r1-compatibilty subcommand and its
registration. The runtime read path for r1_compatibility is untouched.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix pagination in tableland definitions query to stop OOM

QueryDefinitionsCustom built its SQL with OFFSET set to the raw pageIndex
instead of pageIndex*500, so each page overlapped the previous by 499 rows.
The caller in sync-device-definitions-search also broke only when a page
returned fewer than 50 rows (vs. the 500-row page size), so for any
manufacturer with more than 50 definitions the loop kept advancing by one
row while appending a near-duplicate page each iteration. The resulting
documents slice grew by roughly N*(N-50)/2 per make and drove the job OOM.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor sync-device-definitions-search for per-make flush and testability

Splits Execute() into a SearchIndexer interface (with a typesense-backed
implementation) and two pure orchestration functions: buildManufacturerDocuments
converts a single manufacturer's tableland definitions into search entries, and
runSearchSync walks manufacturers and upserts one make at a time. The
per-make flush bounds steady-state memory to one make's documents instead of
retaining the entire catalog until the end, and switches uploads from
per-document Upsert calls to the batched Documents().Import upsert action.

Adds unit tests covering the year filter, field population, pagination
termination, error propagation, and per-make flush behaviour. Tests use the
existing gomock mocks for IdentityAPI and DeviceDefinitionOnChainService plus
a generated MockSearchIndexer; no database is required.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: JamesReate

charts/device-definitions-api/values-prod.yaml

@@ -58,3 +58,10 @@ tolerations: []
 affinity: {}
 podDisruptionBudget:
   minAvailable: 1
+jobs:
+  - name: device-definitions-search-sync
+    schedule: 0 13 * * *
+    args:
+      - '-c'
+      - /device-definitions-api sync-device-definitions-search; CODE=$?; echo "daily device definitions typesense search sync completed"; wget -q --post-data "hello=shutdown" http://localhost:4191/shutdown &> /dev/null; exit $CODE;
+

cmd/device-definitions-api/main.go

@@ -55,7 +55,6 @@ func main() {
 	subcommands.Register(&decodeVINCmd{logger: &logger, settings: &settings}, "")
 	subcommands.Register(&syncDeviceDefinitionSearchCmd{logger: logger, settings: settings, sender: sigSender}, "")
 	subcommands.Register(&deleteDefinition{logger: logger, settings: settings}, "")
-	subcommands.Register(&syncR1CompatibiltyCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&bulkUpdatePowertrain{logger: logger, settings: settings, sender: sigSender}, "")
 
 	if len(os.Args) == 1 {

cmd/device-definitions-api/search_indexer.go

@@ -0,0 +1,53 @@
+package main
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/pkg/errors"
+	"github.com/typesense/typesense-go/typesense"
+	"github.com/typesense/typesense-go/typesense/api"
+)
+
+//go:generate mockgen -source search_indexer.go -destination search_indexer_mock_test.go -package main
+type SearchIndexer interface {
+	RecreateIndex(ctx context.Context, schema *api.CollectionSchema) error
+	UpsertDocuments(ctx context.Context, collectionName string, docs []SearchEntryItem) error
+}
+
+type typesenseSearchIndexer struct {
+	client *typesense.Client
+}
+
+func NewTypesenseSearchIndexer(client *typesense.Client) SearchIndexer {
+	return &typesenseSearchIndexer{client: client}
+}
+
+func (t *typesenseSearchIndexer) RecreateIndex(ctx context.Context, schema *api.CollectionSchema) error {
+	if _, err := t.client.Collection(schema.Name).Delete(ctx); err != nil {
+		// Deletion failure is non-fatal (index may not exist yet) — caller logs.
+		fmt.Printf("RecreateIndex: delete returned %v (continuing)\n", err)
+	}
+	if _, err := t.client.Collections().Create(ctx, schema); err != nil {
+		return errors.Wrap(err, "failed to create collection")
+	}
+	return nil
+}
+
+func (t *typesenseSearchIndexer) UpsertDocuments(ctx context.Context, collectionName string, docs []SearchEntryItem) error {
+	if len(docs) == 0 {
+		return nil
+	}
+	payload := make([]interface{}, 0, len(docs))
+	for _, d := range docs {
+		payload = append(payload, d)
+	}
+	action := "upsert"
+	_, err := t.client.Collection(collectionName).Documents().Import(ctx, payload, &api.ImportDocumentsParams{
+		Action: &action,
+	})
+	if err != nil {
+		return errors.Wrap(err, "failed to import documents")
+	}
+	return nil
+}