Skip to content

Respect tombstone messages #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elffjs merged 4 commits into from
Apr 29, 2026
Merged

Respect tombstone messages #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c33bd97
VOids
elffjs Apr 29, 2026
5bd3c75
Generate
elffjs Apr 29, 2026
fb377a0
Use a real cloudevent commit
elffjs Apr 29, 2026
e4585ea
Use a proper cloudevent tag
elffjs Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/99designs/gqlgen v0.17.89
github.com/ClickHouse/clickhouse-go/v2 v2.43.0
github.com/DIMO-Network/clickhouse-infra v0.0.7
github.com/DIMO-Network/cloudevent v0.2.8
github.com/DIMO-Network/cloudevent v0.2.9
github.com/DIMO-Network/server-garage v0.1.1
github.com/DIMO-Network/shared v1.1.7
github.com/DIMO-Network/token-exchange-api v0.4.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ github.com/DATA-DOG/go-sqlmock v1.5.2 h1:OcvFkGmslmlZibjAjaHm3L//6LiuBgolP7Oputl
github.com/DATA-DOG/go-sqlmock v1.5.2/go.mod h1:88MAG/4G7SMwSE3CeA0ZKzrT5CiOU3OJ+JlNzwDqpNU=
github.com/DIMO-Network/clickhouse-infra v0.0.7 h1:TAsjkFFKu3D5Xg6dwBcRBryjCVSlXsNjVbTwJ4UDlTg=
github.com/DIMO-Network/clickhouse-infra v0.0.7/go.mod h1:XS80lhSJNWBWGgZ+m4j7++zFj1wAXfmtV2gJfhGlabQ=
github.com/DIMO-Network/cloudevent v0.2.8 h1:Q0xGQVPlOshF2LSX/m15Qzi2n4BI0EQDgOM71gEbNsY=
github.com/DIMO-Network/cloudevent v0.2.8/go.mod h1:I/9NcpMozV5Fw194WimhbkAsJtKVZf5UKYJ9hgc8Cdg=
github.com/DIMO-Network/cloudevent v0.2.9 h1:8MxbZtNReMHbwPUGQc2+G5THf08dFxju+npKZFZygJc=
github.com/DIMO-Network/cloudevent v0.2.9/go.mod h1:I/9NcpMozV5Fw194WimhbkAsJtKVZf5UKYJ9hgc8Cdg=
github.com/DIMO-Network/server-garage v0.1.1 h1:EYmyy+Fgi2BNW0Bufn04BViDtb8BCWaN7C7BbEuoI5s=
github.com/DIMO-Network/server-garage v0.1.1/go.mod h1:Z3A1KDUsXey+XhrPhmw/wyCidfrQvmEdWp7nShno7ZM=
github.com/DIMO-Network/shared v1.1.7 h1:5Ex8bZ6BpOjcLj4u7n5Kih1Ho6b9BVJsKpKn4iU2EaM=
Expand Down
10 changes: 6 additions & 4 deletions internal/fetch/rpc/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ func (s *Server) GetLatestIndex(ctx context.Context, req *grpc.GetLatestIndexReq
var err error

if req.GetAdvancedOptions() != nil {
index, err = s.eventService.GetLatestIndexAdvanced(ctx, req.GetAdvancedOptions())
// gRPC callers see no tombstone suppression by default; the GraphQL
// includeDeleted flag is the public surface for opting in.
index, err = s.eventService.GetLatestIndexAdvanced(ctx, req.GetAdvancedOptions(), true)
} else {
index, err = s.eventService.GetLatestIndex(ctx, req.GetOptions())
}
Expand All @@ -63,7 +65,7 @@ func (s *Server) ListIndexes(ctx context.Context, req *grpc.ListIndexesRequest)
var err error

if req.GetAdvancedOptions() != nil {
indexObjs, err = s.eventService.ListIndexesAdvanced(ctx, int(req.GetLimit()), req.GetAdvancedOptions())
indexObjs, err = s.eventService.ListIndexesAdvanced(ctx, int(req.GetLimit()), req.GetAdvancedOptions(), true)
} else {
indexObjs, err = s.eventService.ListIndexes(ctx, int(req.GetLimit()), req.GetOptions())
}
Expand Down Expand Up @@ -92,7 +94,7 @@ func (s *Server) ListCloudEvents(ctx context.Context, req *grpc.ListCloudEventsR
var err error

if req.GetAdvancedOptions() != nil {
metaList, err = s.eventService.ListIndexesAdvanced(ctx, int(req.GetLimit()), req.GetAdvancedOptions())
metaList, err = s.eventService.ListIndexesAdvanced(ctx, int(req.GetLimit()), req.GetAdvancedOptions(), true)
} else {
metaList, err = s.eventService.ListIndexes(ctx, int(req.GetLimit()), req.GetOptions())
}
Expand Down Expand Up @@ -121,7 +123,7 @@ func (s *Server) GetLatestCloudEvent(ctx context.Context, req *grpc.GetLatestClo
var err error

if req.GetAdvancedOptions() != nil {
metadata, err = s.eventService.GetLatestIndexAdvanced(ctx, req.GetAdvancedOptions())
metadata, err = s.eventService.GetLatestIndexAdvanced(ctx, req.GetAdvancedOptions(), true)
} else {
metadata, err = s.eventService.GetLatestIndex(ctx, req.GetOptions())
}
Expand Down
20 changes: 10 additions & 10 deletions internal/graph/base.resolvers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions internal/graph/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ func resolveLimit(limit *int) int {
return defaultLimit
}

// resolveIncludeDeleted maps the GraphQL `includeDeleted` argument (which has
// a default of false in the schema, but may arrive as nil when the caller did
// not supply a value at all) to the eventrepo flag. False means tombstoned
// attestations are suppressed; true means they are returned.
func resolveIncludeDeleted(p *bool) bool {
return p != nil && *p
}

// indexToModel converts a CloudEvent index entry to the GraphQL model,
// using the CloudEventHeader from the library directly.
func indexToModel(idx cloudevent.CloudEvent[eventrepo.ObjectInfo]) *model.CloudEventIndex {
Expand Down
Loading
Loading