Refactor barcode scanner; fix detection not resuming after pause (#870)

Co-authored-by: Vetle Finstad <finstad@Vetles-MacBook-Pro-2.local>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: 3 people

CHANGELOG.md

@@ -10,5 +10,5 @@
         <ToolbarItem IconImageSource="{dui:Icons close_line}"
                      Clicked="Close" />
     </dui:ContentPage.ToolbarItems>
-    <dui:CameraPreview x:Name="CameraPreview" IsInFullscreen="False"/>
+    <dui:CameraPreview x:Name="CameraPreview"/>
 </dui:ContentPage>

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeCounterSample.xaml

@@ -18,7 +18,7 @@ public BarcodeCounterSample()
         {
             Preview = CameraPreview,
             OnCameraFailed = CameraFailed,
-            ScanRectangle = new BarcodeScanRectangleOptions
+            Strategy = new ScanRectangleBarcodeScanStrategy
             {
                 WidthFraction = 0.8f,
                 HeightFraction = 0.3f

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeCounterSample.xaml.cs

@@ -10,5 +10,5 @@
         <ToolbarItem IconImageSource="{dui:Icons close_line}"
                      Clicked="Close" />
     </dui:ContentPage.ToolbarItems>
-    <dui:CameraPreview x:Name="CameraPreview" IsInFullscreen="False"/>
+    <dui:CameraPreview x:Name="CameraPreview"/>
 </dui:ContentPage>

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeOverlaySample.xaml

@@ -27,7 +27,7 @@ await m_barcodeScanner.Start(new BarcodeScannerStartOptions
                 Preview = CameraPreview,
                 OnCameraFailed = CameraFailed,
                 OnBarcodeAcceptedAsync = HandleBarcodeAcceptedAsync,
-                ScanRectangle = new BarcodeScanRectangleOptions
+                Strategy = new ScanRectangleBarcodeScanStrategy
                 {
                     WidthFraction = 0.8f,
                     HeightFraction = 0.3f

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeOverlaySample.xaml.cs

@@ -13,5 +13,5 @@
                      Clicked="ShowTip">
         </ToolbarItem>
     </dui:ContentPage.ToolbarItems>
-    <dui:CameraPreview x:Name="CameraPreview" IsInFullscreen="False"/>
+    <dui:CameraPreview x:Name="CameraPreview"/>
 </dui:ContentPage>

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeScanningSample.xaml

@@ -10,5 +10,5 @@
         <ToolbarItem IconImageSource="{dui:Icons close_line}"
                      Clicked="Close" />
     </dui:ContentPage.ToolbarItems>
-    <dui:CameraPreview x:Name="CameraPreview" IsInFullscreen="False"/>
+    <dui:CameraPreview x:Name="CameraPreview"/>
 </dui:ContentPage>

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeTooltipSample.xaml

@@ -26,7 +26,7 @@ await m_barcodeScanner.Start(new BarcodeScannerStartOptions
                 Preview = CameraPreview,
                 OnCameraFailed = CameraFailed,
                 OnBarcodeAcceptedAsync = HandleBarcodeAcceptedAsync,
-                ScanRectangle = new BarcodeScanRectangleOptions()
+                Strategy = new ScanRectangleBarcodeScanStrategy()
             });
 
             m_barcodeScanner.SetTooltipView(new Label

src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeTooltipSample.xaml.cs

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<dui:ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+                 xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+                 xmlns:dui="http://dips.com/mobile.ui"
+                 x:Class="Playground.EirikSamples.BarcodeScanResumeRepro"
+                 Title="Barcode Resume Repro (#1415)">
+
+    <dui:CameraPreview x:Name="CameraPreview" />
+</dui:ContentPage>

src/app/Playground/EirikSamples/BarcodeScanResumeRepro.xaml

@@ -0,0 +1,86 @@
+using DIPS.Mobile.UI.API.Camera;
+using DIPS.Mobile.UI.API.Camera.BarcodeScanning;
+using DIPS.Mobile.UI.Components.BottomSheets;
+
+namespace Playground.EirikSamples;
+
+/// <summary>
+/// Reproduction for Arena.Mobile#1415:
+/// After scanning a barcode and discarding the result (closing the bottom sheet),
+/// the camera is visible but barcode detection no longer works.
+///
+/// Steps:
+/// 1. Open this page
+/// 2. Scan any barcode/QR code
+/// 3. Close the bottom sheet (discard result)
+/// 4. Try scanning again — observe that detection does not resume
+/// </summary>
+public partial class BarcodeScanResumeRepro
+{
+    private readonly BarcodeScanner m_barcodeScanner;
+
+    public BarcodeScanResumeRepro()
+    {
+        InitializeComponent();
+        m_barcodeScanner = new BarcodeScanner();
+    }
+
+    protected override void OnAppearing()
+    {
+        base.OnAppearing();
+        _ = StartScanning();
+    }
+
+    protected override void OnDisappearing()
+    {
+        m_barcodeScanner.StopAndDispose();
+        base.OnDisappearing();
+    }
+
+    private async Task StartScanning()
+    {
+        try
+        {
+            await m_barcodeScanner.Start(new BarcodeScannerStartOptions
+            {
+                Preview = CameraPreview,
+                OnCameraFailed = e => DisplayAlert("Camera failed", e.Message, "OK"),
+                OnBarcodeAcceptedAsync = OnBarcodeAccepted,
+                Strategy = new ScanRectangleBarcodeScanStrategy
+                {
+                    WidthFraction = 0.8f,
+                    HeightFraction = 0.3f
+                }
+            });
+        }
+        catch (Exception ex)
+        {
+            Console.WriteLine($"[BarcodeScanResumeRepro] Start failed: {ex}");
+        }
+    }
+
+    private Task OnBarcodeAccepted(BarcodeScanResult result)
+    {
+        m_barcodeScanner.PauseScanning(resetOverlay: false);
+
+        var sheet = new BottomSheet { Title = "Scan Result" };
+        sheet.Content = new VerticalStackLayout
+        {
+            Padding = 16,
+            Children =
+            {
+                new Label { Text = $"Barcode: {result.Barcode.RawValue}", Margin = new Thickness(0, 0, 0, 8) },
+                new Label { Text = $"Format: {result.Barcode.Format}" }
+            }
+        };
+
+        sheet.Closed += (_, _) =>
+        {
+            Console.WriteLine("[BarcodeScanResumeRepro] Sheet closed, calling ResumeScanning()");
+            m_barcodeScanner.ResumeScanning();
+        };
+
+        sheet.Open();
+        return Task.CompletedTask;
+    }
+}