Fixed OnPropertyChanged override on ContentPage not passing in CallerMemberName (#890)

Author: VegardHV

CHANGELOG.md

@@ -1,3 +1,6 @@
+## [60.2.9]
+- Fixed issue where CallerMemberName was not passed on OnPropertyChanged override. Affects ContentPage, Button, Chip, ContextMenuItem, ContextMenuSeparatorItem, ImageButton, ActivityIndicator and SingleLineInputField.
+
 ## [60.2.8]
 - [SystemMessage][iOS] Fixed system messages not being removed when displayed inside a modal.
 

src/library/DIPS.Mobile.UI/Components/Buttons/Button.cs

@@ -1,3 +1,4 @@
+using System.Runtime.CompilerServices;
 using DIPS.Mobile.UI.Resources.Styles.Button;
 
 namespace DIPS.Mobile.UI.Components.Buttons
@@ -38,7 +39,7 @@ protected override void OnSizeAllocated(double width, double height)
             }
         }
 
-        protected override void OnPropertyChanged(string propertyName = null)
+        protected override void OnPropertyChanged([CallerMemberName] string propertyName = null)
         {
             base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/Chips/iOS/Chip.cs

@@ -1,3 +1,4 @@
+using System.Runtime.CompilerServices;
 using DIPS.Mobile.UI.API.Accessibility;
 using DIPS.Mobile.UI.Effects.Touch;
 using DIPS.Mobile.UI.Resources.LocalizedStrings.LocalizedStrings;
@@ -193,7 +194,7 @@ private void OnTappedButtonChip(bool didTouchCloseButton)
         }
     }
 
-    protected override void OnPropertyChanged(string propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string propertyName = null)
     {
         base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/ContextMenus/ContextMenuItem.cs

@@ -1,3 +1,5 @@
+using System.Runtime.CompilerServices;
+
 namespace DIPS.Mobile.UI.Components.ContextMenus;
 
 /// <summary>
@@ -27,7 +29,7 @@ internal void SendClicked(ContextMenu contextMenu)
     }
 
 #if __IOS__
-    protected override void OnPropertyChanged(string propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string propertyName = null)
     {
         base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/ContextMenus/ContextMenuSeparatorItem.cs

@@ -1,3 +1,5 @@
+using System.Runtime.CompilerServices;
+
 namespace DIPS.Mobile.UI.Components.ContextMenus;
 
 public class ContextMenuSeparatorItem : Element, IContextMenuItem
@@ -20,7 +22,7 @@ public bool IsVisible
     public ContextMenu? ContextMenu { get; set; }
 
 #if __IOS__
-    protected override void OnPropertyChanged(string propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string propertyName = null)
     {
         base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/Images/ImageButton/ImageButton.cs

@@ -1,12 +1,13 @@
 
+using System.Runtime.CompilerServices;
 using Microsoft.Maui.Platform;
 namespace DIPS.Mobile.UI.Components.Images.ImageButton;
 
 public partial class ImageButton : Microsoft.Maui.Controls.ImageButton
 {
     //TODO: Fix when MAUI fixes: https://github.com/dotnet/maui/issues/18001
 #if __ANDROID__
-    protected override void OnPropertyChanged(string propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string propertyName = null)
     {
         base.OnPropertyChanged(propertyName);
         if (propertyName.Equals(IsVisibleProperty.PropertyName))

src/library/DIPS.Mobile.UI/Components/Loading/Android/ActivityIndicator.cs

@@ -1,3 +1,4 @@
+using System.Runtime.CompilerServices;
 using DIPS.Mobile.UI.Components.Loading.Android;
 using DIPS.Mobile.UI.Extensions.Android;
 using Google.Android.Material.ProgressIndicator;
@@ -6,7 +7,7 @@ namespace DIPS.Mobile.UI.Components.Loading;
 
 public partial class ActivityIndicator
 {
-    protected override void OnPropertyChanged(string? propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string? propertyName = null)
     {
         base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/Pages/ContentPage.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Runtime.CompilerServices;
 using DIPS.Mobile.UI.API.Diagnostics;
 using DIPS.Mobile.UI.API.Library;
 
@@ -65,7 +66,7 @@ private void OnLoaded(object? sender, EventArgs e)
             }
         }
 
-        protected override void OnPropertyChanged(string? propertyName = null)
+        protected override void OnPropertyChanged([CallerMemberName] string? propertyName = null)
         {
             base.OnPropertyChanged(propertyName);
 

src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs

@@ -1,3 +1,4 @@
+using System.Runtime.CompilerServices;
 using DIPS.Mobile.UI.API.Accessibility;
 using DIPS.Mobile.UI.Effects.Touch;
 using DIPS.Mobile.UI.Formatters;
@@ -136,7 +137,7 @@ private void SetupInputView()
         InnerGrid.Add(InputView, 0, 1);
     }
 
-    protected override void OnPropertyChanged(string? propertyName = null)
+    protected override void OnPropertyChanged([CallerMemberName] string? propertyName = null)
     {
         base.OnPropertyChanged(propertyName);