Skip to content

Commit c4ef0f5

Browse files
authored
Merge pull request #8684 from ryuwd/fix/bad-escaping
fix: handle NoneType correctly inside __escapeString and _escapeValues
2 parents c24c5bd + 3a4ded2 commit c4ef0f5

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/DIRAC/Core/Utilities/MySQL.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,8 @@ def __escapeString(self, myString, connection=None):
611611
if not retDict["OK"]:
612612
return retDict
613613
connection = retDict["Value"]
614-
614+
if myString is None:
615+
return S_OK("NULL")
615616
if isinstance(myString, bytes):
616617
myString = myString.decode()
617618
try:
@@ -721,7 +722,9 @@ def _escapeValues(self, inValues=None):
721722
return S_OK(inEscapeValues)
722723

723724
for value in inValues:
724-
if isinstance(value, str):
725+
if value is None:
726+
inEscapeValues.append("NULL")
727+
elif isinstance(value, str):
725728
retDict = self.__escapeString(value, connection=connection)
726729
if not retDict["OK"]:
727730
return retDict

0 commit comments

Comments
 (0)