Skip to content

Commit e068d9f

Browse files
committed
fix: bug fix for ProxyDB.logAction
1 parent a260ef7 commit e068d9f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/DIRAC/FrameworkSystem/DB/ProxyDB.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ def logAction(self, action, issuerDN, targetDN):
833833
except KeyError:
834834
return S_ERROR("Can't escape from death")
835835
cmd = "INSERT INTO `ProxyDB_Log` ( Action, IssuerDN, IssuerGroup, TargetDN, TargetGroup, Timestamp ) VALUES "
836-
cmd += f"( {sAction}, {sIssuerDN}, 'IssuerGroup' {sTargetDN}, 'TargetGroup', UTC_TIMESTAMP() )"
836+
cmd += f"( {sAction}, {sIssuerDN}, 'IssuerGroup', {sTargetDN}, 'TargetGroup', UTC_TIMESTAMP() )"
837837
retVal = self._update(cmd)
838838
if not retVal["OK"]:
839839
self.log.error("Can't add a proxy action log: ", retVal["Message"])

src/DIRAC/FrameworkSystem/Service/ProxyManagerHandler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def export_getProxy(self, userDN, userGroup, requestPem, requiredLifetime):
178178
return result
179179
forceLimited = result["Value"]
180180

181-
self.__proxyDB.logAction("download proxy", credDict["DN"], credDict["group"], userDN, userGroup)
181+
self.__proxyDB.logAction("download proxy", credDict["DN"], userDN)
182182
return self.__getProxy(userDN, userGroup, requestPem, requiredLifetime, forceLimited)
183183

184184
def __getProxy(self, userDN, userGroup, requestPem, requiredLifetime, forceLimited):
@@ -226,7 +226,7 @@ def export_getVOMSProxy(self, userDN, userGroup, requestPem, requiredLifetime, v
226226
return result
227227
forceLimited = result["Value"]
228228

229-
self.__proxyDB.logAction("download voms proxy", credDict["DN"], credDict["group"], userDN, userGroup)
229+
self.__proxyDB.logAction("download voms proxy", credDict["DN"], userDN)
230230
return self.__getVOMSProxy(userDN, userGroup, requestPem, requiredLifetime, vomsAttribute, forceLimited)
231231

232232
def __getVOMSProxy(self, userDN, userGroup, requestPem, requiredLifetime, vomsAttribute, forceLimited):

0 commit comments

Comments
 (0)