Skip to content

[8.0] Add PreferredURLPatterns for URL sorting#8065

Merged
fstagni merged 1 commit intoDIRACGrid:rel-v8r0from
chrisburr:url-ordering
May 20, 2025
Merged

[8.0] Add PreferredURLPatterns for URL sorting#8065
fstagni merged 1 commit intoDIRACGrid:rel-v8r0from
chrisburr:url-ordering

Conversation

@chrisburr
Copy link
Copy Markdown
Member

See the included docs for motivation.

BEGINRELEASENOTES

*Configuration
NEW: Add PreferredURLPattern for URL sorting

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Feb 28, 2025
@chaen
Copy link
Copy Markdown
Contributor

chaen commented Mar 3, 2025

Looks good to me but I let somebody from another VO have a look, because it may be of interest to them (maybe @iueda @hmiyake , as they have services scattered around the globe ? )

@hmiyake
Copy link
Copy Markdown
Contributor

hmiyake commented Mar 3, 2025

That's interesting. We are categorizing our servers to some groups (e.g. having UPS or not), then sometimes modify URLs to change active servers.

For such operation I prefer to change single value than list, since error proofing.

Let me gather comments to the PR from our colleagues.

@chrisburr
Copy link
Copy Markdown
Member Author

At the moment this is on a per system basis, though maybe it would make sense to move globally for all URLs? Thoughts?

That's interesting. We are categorizing our servers to some groups (e.g. having UPS or not), then sometimes modify URLs to change active servers.

If it would be useful I could support a list of regexes, i.e.

    PreferredURLPatterns = .*\.preferred\.invalid/.*
    PreferredURLPatterns += .*\.secondary\.invalid/.*
    PreferredURLPatterns += .*\.tertiary\.invalid/.*

@hmiyake What would you prefer?

@hmiyake
Copy link
Copy Markdown
Contributor

hmiyake commented Mar 6, 2025

I wanted to ask the global option! For my user case, it completely matches.

A list of regexes are also helpful to give priority... I like both!

@chrisburr chrisburr changed the title [8.0] Add PreferredURLPattern for URL sorting [8.0] Add PreferredURLPatterns for URL sorting May 20, 2025
@fstagni fstagni merged commit 2e4317e into DIRACGrid:rel-v8r0 May 20, 2025
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels May 20, 2025
@DIRACGridBot
Copy link
Copy Markdown

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/15140420840

Failed:

  • integration
    cherry-pick 2e4317e into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-2e4317e76-integration
    git cherry-pick -x -m 1 2e4317e76
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #8065 Add PreferredURLPatterns for URL sorting' --author='Chris Burr <christopher.burr@cern.ch>'
    git push -u origin cherry-pick-2-2e4317e76-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Add PreferredURLPatterns for URL sorting' \
         --body 'Sweep #8065 `Add PreferredURLPatterns for URL sorting` to `integration`.
    
    Adding original author @chrisburr as watcher.
    
    BEGINRELEASENOTES
    
    *Configuration
    NEW: Add PreferredURLPattern for URL sorting
    
    ENDRELEASENOTES
    Closes #8201'

fstagni pushed a commit to fstagni/DIRAC that referenced this pull request May 20, 2025
chrisburr added a commit to fstagni/DIRAC that referenced this pull request May 21, 2025
fstagni pushed a commit to fstagni/DIRAC that referenced this pull request Jul 3, 2025
maxnoe pushed a commit to maxnoe/DIRAC that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants