[8.0] Don't use string processing on X509 name objects#8091
Merged
chrisburr merged 1 commit intoDIRACGrid:rel-v8r0from Mar 26, 2025
Merged
[8.0] Don't use string processing on X509 name objects#8091chrisburr merged 1 commit intoDIRACGrid:rel-v8r0from
chrisburr merged 1 commit intoDIRACGrid:rel-v8r0from
Conversation
DIRACGridBot
added
the
alsoTargeting:integration
chrisburr
approved these changes
Mar 26, 2025
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Mar 26, 2025
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/14084044485 Successful:
|
maxnoe
pushed a commit
to maxnoe/DIRAC
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We've found that users with a ',' (comma) character in their DN can't run
dirac-proxy-init: it crashes (I'm a little surprised that no-one has run into this before!). This is caused by the splitting of the DN by commas, which then can't find the "=" in one of the sections.I'm a little dubious about whether this patch is upsetting the M2Crypto SWIG memory management by potentially creating multiple owners of the X509_Name_Entry sub-objects. Maybe @chaen can comment? (Although I guess we'll see if anything crashes in the unit/system tests too...)
Regards,
Simon
Adding @marianne013 as a watcher.
BEGINRELEASENOTES
*Core
FIX: Don't use string processing on X509 name objects
ENDRELEASENOTES