Skip to content

[8.0] Don't use string processing on X509 name objects #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisburr merged 1 commit into from
Mar 26, 2025
Merged

[8.0] Don't use string processing on X509 name objects #8091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/DIRAC/Core/Security/m2crypto/X509Certificate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,11 @@ def generateProxyCertFromIssuer(cls, x509Issuer, x509ExtensionStack, proxyKey, l
proxySubject = M2Crypto.X509.X509_Name()

issuerSubjectObj = x509Issuer.__certObj.get_subject()
# pylint: disable=no-member
issuerSubjectParts = issuerSubjectObj.as_text(flags=M2Crypto.m2.XN_FLAG_RFC2253).split(",")

# XN_FLAG_RFC2253 prints in reverse order but DIRAC has historically used the standard order
for isPart in issuerSubjectParts[::-1]:
nid, val = isPart.split("=", 1)
proxySubject.add_entry_by_txt(field=nid, type=M2Crypto.ASN1.MBSTRING_ASC, entry=val, len=-1, loc=-1, set=0)
# Copy the X509 entry components into the new name
for entry in issuerSubjectObj:
# pylint: disable=no-member
M2Crypto.m2.x509_name_add_entry(proxySubject.x509_name, entry.x509_name_entry, -1, 0)

# Finally we add a random Common Name component. And we might as well use the serial.. :)
proxySubject.add_entry_by_txt(
Expand Down
Loading