[9.0] Follow DiracX client changes#8117
Merged
chaen merged 2 commits intoDIRACGrid:integrationfrom Apr 4, 2025
Merged
Conversation
chrisburr
force-pushed
the
diracx-client-fixes
branch
from
303a5e7 to
68f9862
Compare
chaen
reviewed
Apr 4, 2025
|
|
||
| @contextmanager | ||
| def DiracXClient() -> _DiracClient: | ||
| def DiracXClient() -> Iterator[SyncDiracClient]: |
Member
Author
There was a problem hiding this comment.
As this function yields an instance of SyncDiracClient. The previous type hint is wrong. The contextmanager decorator then transforms Generator[T, None, None] -> ContextManager[T].
(Iterator[T] is an alias for Generator[T, None, None])
chaen
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for DIRACGrid/diracx#441