fix (DIRAC): ensure host credentials passed to DIRAC.initialize are not ignored in case passed as list#8130
Conversation
…s a list instead of tuple
| if isinstance( | ||
| host_credentials, | ||
| ( | ||
| tuple, | ||
| list, | ||
| ), | ||
| ): |
There was a problem hiding this comment.
| if isinstance( | |
| host_credentials, | |
| ( | |
| tuple, | |
| list, | |
| ), | |
| ): | |
| if isinstance(host_credentials, (tuple, list)): |
|
Please rebase also. |
| if isinstance(host_credentials, tuple): | ||
| gConfigurationData.setOptionInCFG("/DIRAC/Security/CertFile", str(host_credentials[0])) | ||
| gConfigurationData.setOptionInCFG("/DIRAC/Security/KeyFile", str(host_credentials[1])) | ||
| if isinstance( |
There was a problem hiding this comment.
Actually this if shouldnt' exist at all, it doesn't even match the type hint.
@fstagni Can you take care of it?
There was a problem hiding this comment.
If this is used being used to set UseServerCertificate = yes then set it in the config file next to CertFile/KeyFile
There was a problem hiding this comment.
This I added in 2fd668d in order to run these tests using the certificates from standard location. This was a quick way of doing it, if you want something cleaner I would suggest to add another parameter (boolean) to initialize for only setting UseServerCertificate (all test calls should then be updated).
|
I think that can replaced by #8131. Comment if you don't think so. |
3 participants
will be hotfixed on cvmfs
cc @fstagni
BEGINRELEASENOTES
*DIRAC
FIX: ensure host credentials are not ignored in case passed as a list and not a tuple
ENDRELEASENOTES