Skip to content

fix: prevent any local-UTC offset being introduced in plots#8151

Merged
fstagni merged 1 commit intoDIRACGrid:integrationfrom
ryuwd:roneil-fix-graph-datetime-offset
Apr 25, 2025
Merged

fix: prevent any local-UTC offset being introduced in plots#8151
fstagni merged 1 commit intoDIRACGrid:integrationfrom
ryuwd:roneil-fix-graph-datetime-offset

Conversation

@ryuwd
Copy link
Copy Markdown
Contributor

@ryuwd ryuwd commented Apr 14, 2025

.astimezone() interprets any datetime with tzinfo=None to be a local datetime. This means UTC naive datetime objects have local-UTC offsets introduced.

BEGINRELEASENOTES

*GraphUtilities
FIX: prevent any local-UTC offset being introduced in plots

ENDRELEASENOTES

@ryuwd ryuwd requested review from atsareg and fstagni as code owners April 14, 2025 10:01
@fstagni
Copy link
Copy Markdown
Contributor

fstagni commented Apr 14, 2025

Thanks! Can you target rel-v8r0 branch for this one?

@ryuwd
Copy link
Copy Markdown
Contributor Author

ryuwd commented Apr 14, 2025

Thanks! Can you target rel-v8r0 branch for this one?

No problem ! Would this eventually end up patching integration, where the problem is?

Comment thread src/DIRAC/Core/Utilities/Graphs/GraphUtilities.py
@fstagni
Copy link
Copy Markdown
Contributor

fstagni commented Apr 14, 2025

Thanks! Can you target rel-v8r0 branch for this one?

No problem ! Would this eventually end up patching integration, where the problem is?

It will

@chrisburr
Copy link
Copy Markdown
Member

Is it worth touching v8 with this, the plots were working there so we can only break it.

@fstagni fstagni merged commit d201a23 into DIRACGrid:integration Apr 25, 2025
23 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants