Skip to content

Moved killPilot to diracAdmin itself#8203

Merged
fstagni merged 1 commit intoDIRACGrid:integrationfrom
Robin-Van-de-Merghel:robin-move-killpilot
May 22, 2025
Merged

Moved killPilot to diracAdmin itself#8203
fstagni merged 1 commit intoDIRACGrid:integrationfrom
Robin-Van-de-Merghel:robin-move-killpilot

Conversation

@Robin-Van-de-Merghel
Copy link
Copy Markdown
Contributor

@Robin-Van-de-Merghel Robin-Van-de-Merghel commented May 21, 2025 •
edited
Loading

BEGINRELEASENOTES

*PilotManagerHandler
CHANGE: Moved killpilot to diracAdmin itself to avoid migrating it to DiracX while migrating PilotManagerHandler

This is useful later because in DiracX we can't use it for now: it needs a proxy to contact the CS + we would need to import MySQLdb in DiracX (see error below):

from DIRAC.Core.Utilities.MySQL import MySQL
  File "/opt/conda/lib/python3.11/site-packages/DIRAC/Core/Utilities/MySQL.py", line 155, in <module>
    import MySQLdb
ModuleNotFoundError: No module named 'MySQLdb'

This error occurred while importing killPilotsInQueues from DiracX via an import.

ENDRELEASENOTES

fstagni
fstagni reviewed May 21, 2025
View reviewed changes
Comment thread src/DIRAC/Interfaces/API/DiracAdmin.py Outdated
@chrisburr
Copy link
Copy Markdown
Member

chrisburr commented May 21, 2025

I don't see how this can be useful for DiracX as it can't use src/DIRAC/Interfaces/API/DiracAdmin.py

@Robin-Van-de-Merghel
Copy link
Copy Markdown
Contributor Author

Robin-Van-de-Merghel commented May 21, 2025

I don't see how this can be useful for DiracX as it can't use src/DIRAC/Interfaces/API/DiracAdmin.py

This is useful because we can't move this part to DiracX because of the authentification, and because we want to move the PilotManagerClient to use the FutureClient without killPilots (which can't be moved to DiracX as said previously).

@chrisburr
Copy link
Copy Markdown
Member

chrisburr commented May 21, 2025

Ah I misunderstood the description, yes that makes sense if that is the only place using this. Though I guess it should be backported+deprecated into v8.

@Robin-Van-de-Merghel
Copy link
Copy Markdown
Contributor Author

Robin-Van-de-Merghel commented May 21, 2025

Ah I misunderstood the description, yes that makes sense if that is the only place using this. Though I guess it should be backported+deprecated into v8.

(I don't know DIRAC that much) You mean applying also for v8?

@Robin-Van-de-Merghel Robin-Van-de-Merghel mentioned this pull request May 14, 2025
Open
18 tasks
@fstagni
Copy link
Copy Markdown
Contributor

fstagni commented May 22, 2025

Ah I misunderstood the description, yes that makes sense if that is the only place using this. Though I guess it should be backported+deprecated into v8.

It just needs to be deprecated, I take care.

@fstagni fstagni merged commit 9f4c39a into DIRACGrid:integration May 22, 2025
24 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fstagni fstagni fstagni approved these changes

@atsareg atsareg Awaiting requested review from atsareg atsareg is a code owner

Assignees

No one assigned

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Robin-Van-de-Merghel @chrisburr @fstagni @DIRACGridBot