feat: remove PilotManager dependency from HTCondorCE#8211
Merged
fstagni merged 1 commit intoJun 2, 2025
Merged
Conversation
fstagni
reviewed
Jun 2, 2025
6dd34b5 to
b237b3d
Compare
fstagni
reviewed
Jun 2, 2025
|
|
||
| return result | ||
| """Method to return information on running and pending jobs.""" | ||
| return S_ERROR("getCEStatus not implemented for HTCondorCEComputingElement") |
Contributor
There was a problem hiding this comment.
This is slightly misleading, as one can read it like "not yet implemented, maybe it will". So better specify here why it's better not implemented.
Contributor
Author
There was a problem hiding this comment.
I've changed the message, please let me know if you want further details.
b237b3d to
cdca59b
Compare
fstagni
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following change was not accepted in #5406, but I still think it makes sense because:
WMSagents/services useResources/Computing(Resources/Computingshould work as a standalone, so without having to interact with aWMSservice).PilotAgentsDB, so we duplicate the operation:DIRAC/src/DIRAC/WorkloadManagementSystem/Agent/SiteDirector.py
Lines 369 to 408 in 889337e
Resources/Computingfromdiracx, we would have troubles becauseHTCondorComputingElementrelies on a DIRAC service.Any reason to keep this dependency?
BEGINRELEASENOTES
*Resources
CHANGE: remove dependency from HTCondorComputingElement to PilotManager
ENDRELEASENOTES