[sweep:integration] robot cert nicknames#8259
Merged
fstagni merged 1 commit intoJul 15, 2025
Merged
Conversation
chrisburr
approved these changes
Jul 14, 2025
chrisburr
reviewed
Jul 14, 2025
Comment on lines
+92
to
+98
| nameok = False | ||
| if len(names) > 1: | ||
| for name in names[1:]: | ||
| if not name.isdigit(): | ||
| nameok = True | ||
| if nameok: | ||
| names.pop(0) |
Member
There was a problem hiding this comment.
Is the logic here intended to be this (I think it's equivalent to what is currently written):
Suggested change
| nameok = False | |
| if len(names) > 1: | |
| for name in names[1:]: | |
| if not name.isdigit(): | |
| nameok = True | |
| if nameok: | |
| names.pop(0) | |
| for name in names[1:]: | |
| if not name.isdigit(): | |
| # Remove the "robot.*" prefix | |
| names.pop(0) | |
| break |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep #8255
robot cert nicknamestointegration.Adding original author @marianne013 as watcher.
BEGINRELEASENOTES
*ConfigurationSystem
FIX: Stops VOMS2CSSynchronizer crashing on robot DNs that don't follow the CERN pattern.
ENDRELEASENOTES