fix: update logAction call sites missed in e4a032d6f3#8502
Closed
ryuwd wants to merge 1 commit intoDIRACGrid:integrationfrom
Closed
fix: update logAction call sites missed in e4a032d6f3#8502ryuwd wants to merge 1 commit intoDIRACGrid:integrationfrom
ryuwd wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
Contributor
Author
|
duplicate of #8500 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e4a032d removed the
issuerGroupandtargetGroupparameters fromProxyDB.logAction(). Two call sites inProxyManagerHandlerwere not updated:export_getProxy)export_getVOMSProxy)This results in
TypeError: ProxyDB.logAction() takes 4 positional arguments but 6 were givenwhen downloading proxies.Also fixes a missing comma in the
logActionSQL INSERT statement.