fix: install non-released versions: handle space#8505
Open
fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
Open
fix: install non-released versions: handle space#8505fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
chaen
reviewed
Apr 13, 2026
| self.log.info("Downloaded DIRACOS installer to", installer.name) | ||
|
|
||
| directory = version if released_version else version.split("@")[1].split("#")[0] | ||
| directory = version if released_version else version.split()[2].split("@")[1].split("#")[0] |
Contributor
There was a problem hiding this comment.
Ins't .replace(' ','') safer as I naively would never have put any space there
Contributor
Author
There was a problem hiding this comment.
The space now is always present, since #8496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.