feat: Add a new eval helper function#8536
Merged
Merged
Conversation
Contributor
|
Shouldn't this be targeting |
Member
Author
|
My plan was to target integration for doing testing and then worry about backporting as a later step, if that approach is OK with you? Regards, |
Contributor
Yes. BTW, stating the obvious, but the test failures here have nothing to do with your PR specifically, will be sorted elsewhere. |
fstagni
reviewed
May 18, 2026
Contributor
There was a problem hiding this comment.
Can you ask your LLM to rewrite this in a more compact way though pytest parametrize?
Member
Author
There was a problem hiding this comment.
Sure, that's tidied up now...
Regards,
Simon
sfayer
force-pushed
the
safer_eval
branch
3 times, most recently
from
81f9d97 to
2c3866d
Compare
fstagni
approved these changes
May 18, 2026
fstagni
approved these changes
May 27, 2026
Contributor
|
Where do you plan to use this btw ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new utility function for doing eval.
BEGINRELEASENOTES
*Core
CHANGE: New eval helper function
ENDRELEASENOTES