Speed up Client_RequestTasks test path gen#8539
Merged
Merged
Conversation
fstagni
approved these changes
May 18, 2026
fstagni
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've found the Client_RequestTasks test to be flaky on my machine: It sometimes overruns the 500ms deadline set on hypothesis. The cause of this is the regex based LFN generation taking a long time to generate valid results: Sometimes if it gets unlucky it doesn't manage to generate enough valid candidates in time. (The deadline is likely disabled in the CI, so it probably doesn't show up as an issue there).
I believe adjusting the strategy to joining random strings with "/" instead keeps approximately the same test parameter space, but runs in ~10 seconds instead the original ~93.
This still feels a bit suboptimal: The actual test runtime is 1 second, the other 9 seconds are spent generating the random input LFNs for inputData lists.
Regards,
Simon
BEGINRELEASENOTES
*RequestManagement
FIX: Speed up Client_RequestTasks test path gen
ENDRELEASENOTES