Skip to content

fix: Changed test to use conda instead of an old docker container #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Robin-Van-de-Merghel wants to merge 1 commit into from
Closed

fix: Changed test to use conda instead of an old docker container #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 48 additions & 37 deletions .github/workflows/basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- name: Run shellcheck
run: |
find tests/CI -name '*.sh' -print0 | xargs -0 -n1 shellcheck --external-sources;
- uses: actions/checkout@v3
- name: Run shellcheck
run: |
find tests/CI -name '*.sh' -print0 | xargs -0 -n1 shellcheck --external-sources;

pycodestyle:
runs-on: ubuntu-24.04
Expand All @@ -27,23 +27,26 @@ jobs:
- 3.6.15
- 3.9.17

container: python:${{ matrix.python }}-slim
steps:
- uses: actions/checkout@v3
- name: Installing dependencies
run: |
python -m pip install pycodestyle
- name: Run pycodestyle
run: |
if [[ "${REFERENCE_BRANCH}" != "" ]]; then
git remote add upstream https://github.com/DIRACGrid/Pilot.git
git fetch --no-tags upstream "${REFERENCE_BRANCH}"
git branch -vv
git diff -U0 "upstream/${REFERENCE_BRANCH}" | pycodestyle --diff
fi
env:
REFERENCE_BRANCH: ${{ github['base_ref'] || github['head_ref'] }}

- uses: actions/checkout@v3
- name: Set up Conda with Miniconda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}
activate-environment: base
- name: Installing dependencies
run: conda install -y pycodestyle
- name: Run pycodestyle
run: |
if [[ "${REFERENCE_BRANCH}" != "" ]]; then
git remote add upstream https://github.com/DIRACGrid/Pilot.git
git fetch --no-tags upstream "${REFERENCE_BRANCH}"
git branch -vv
git diff -U0 "upstream/${REFERENCE_BRANCH}" | pycodestyle --diff
fi
env:
REFERENCE_BRANCH: ${{ github['base_ref'] || github['head_ref'] }}

pytest:
runs-on: ubuntu-24.04
Expand All @@ -57,17 +60,21 @@ jobs:
- 3.6.15
- 3.9.17

container: python:${{ matrix.python }}-slim
steps:
- uses: actions/checkout@v3
- name: Installing dependencies
run: |
python -m pip install pytest mock
apt-get update
apt install -y voms-clients
- name: Run pytest
run: pytest

- uses: actions/checkout@v3
- name: Set up Conda with Miniconda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}
activate-environment: base
- name: Installing dependencies
run: |
conda install -y pytest mock
sudo apt-get update
sudo apt-get install -y voms-clients
- name: Run pytest
run: pytest

pylint:
runs-on: ubuntu-24.04
Expand All @@ -81,11 +88,15 @@ jobs:
- 3.6.15
- 3.9.17

container: python:${{ matrix.python }}-slim
steps:
- uses: actions/checkout@v3
- name: Installing dependencies
run: |
python -m pip install pylint
- name: Run pylint
run: pylint -E Pilot/
- uses: actions/checkout@v3
- name: Set up Conda with Miniconda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}
activate-environment: base
- name: Installing dependencies
run: conda install -y pylint
- name: Run pylint
run: pylint -E Pilot/
Loading