Skip to content

Commit 03e9d6d

Browse files
committed
chore: update diagram and bump version
1 parent 17c3318 commit 03e9d6d

5 files changed

Lines changed: 25 additions & 6 deletions

File tree

diracx/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type: application
1111
# This is the chart version. This version number should be incremented each time you make changes
1212
# to the chart and its templates, including the app version.
1313
# Versions are expected to follow Semantic Versioning (https://semver.org/)
14-
version: "1.0.19"
14+
version: "1.0.20"
1515

1616
# This is the version number of the application being deployed. This version number should be
1717
# incremented each time you make changes to the application. Versions are not expected to

diracx/templates/diracx/cleanup-authdb/cronjob.yaml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
{{/* Define common volume mounts for reusability */}}
44
{{- $commonVolumeMounts := list }}
55
{{- $commonVolumeMounts = append $commonVolumeMounts (dict "mountPath" "/entrypoint.sh" "name" "container-entrypoint" "subPath" "entrypoint.sh") }}
6+
{{- if and .Values.developer.enabled .Values.developer.enableCoverage }}
7+
{{- $commonVolumeMounts = append $commonVolumeMounts (dict "mountPath" "/diracx-coveragerc" "name" "container-entrypoint" "subPath" "coveragerc") }}
8+
{{- $commonVolumeMounts = append $commonVolumeMounts (dict "mountPath" "/coverage-reports" "name" "coverage-data" "readOnly" false) }}
9+
{{- end }}
610
{{- if and .Values.developer.enabled .Values.developer.mountedPythonModulesToInstall }}
711
{{- $commonVolumeMounts = append $commonVolumeMounts (dict "mountPath" .Values.developer.sourcePath "name" "diracx-code-mount" "readOnly" true) }}
812
{{- range $module := .Values.developer.mountedPythonModulesToInstall }}
@@ -21,6 +25,8 @@ metadata:
2125
namespace: {{ .Release.Namespace }}
2226
spec:
2327
schedule: {{ $.Values.cleanupAuthDB.schedule | quote }}
28+
successfulJobsHistoryLimit: 3
29+
failedJobsHistoryLimit: 1
2430
jobTemplate:
2531
spec:
2632
template:
@@ -29,6 +35,7 @@ spec:
2935
containers:
3036
- name: {{ .Chart.Name }}-cleanup
3137
image: "{{ include "diracx.servicesImage" . }}"
38+
imagePullPolicy: {{ .Values.global.imagePullPolicy }}
3239
command: ["/bin/bash", "/entrypoint.sh"]
3340
args: ["/bin/bash", "/scripts/cleanup-authdb"]
3441
envFrom:
@@ -45,8 +52,6 @@ spec:
4552
subPath: jwks.json
4653
- name: scripts
4754
mountPath: /scripts
48-
resources:
49-
{{- toYaml .Values.cleanupAuthDB.resources | nindent 16 }}
5055
volumes:
5156
- name: keystore
5257
secret:
@@ -67,6 +72,11 @@ spec:
6772
sizeLimit: 5Mi
6873
{{- end }}
6974
{{- end }}
75+
{{- if and .Values.developer.enabled .Values.developer.enableCoverage }}
76+
- name: coverage-data
77+
persistentVolumeClaim:
78+
claimName: pvc-coverage
79+
{{- end }}
7080
- name: container-entrypoint
7181
configMap:
7282
name: diracx-container-entrypoint

diracx/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,9 @@ initKeyStore:
105105
enabled: true
106106

107107
cleanupAuthDB:
108+
# -- Enable the AuthDB cleanup CronJob
108109
enabled: true
110+
# -- Cron schedule for AuthDB cleanup (default: monthly on the 1st)
109111
schedule: "0 0 1 * *"
110112

111113
developer:

docs/admin/explanations/architecture_diagram.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ config:
55
flowchart TD
66

77
subgraph k8s_instance ["K8s Instance: diracx"]
8-
subgraph helm_chart ["Helm Chart: diracx 1.0.19"]
8+
subgraph helm_chart ["Helm Chart: diracx 1.0.20"]
99
subgraph k8s_app ["K8s Application: diracx"]
1010
ing_diracx{{"ing: diracx"}}
1111
svc_diracx(("svc: diracx"))
1212
svc_diracx_web(("svc: diracx-web"))
1313
deploy_diracx["deploy: diracx"]
1414
deploy_diracx_web["deploy: diracx-web"]
15+
cronjob_diracx_cleanup_authdb(["cronjob: diracx-cleanup-authdb"])
16+
cm_diracx_cleanup_authdb[("cm: diracx-cleanup-authdb")]
1517
cm_mysql_init_diracx_dbs[("cm: mysql-init-diracx-dbs")]
1618
secret_diracx_secrets>"secret: diracx-secrets"]
1719
sa_diracx[["sa: diracx"]]
@@ -51,6 +53,9 @@ flowchart TD
5153
job_diracx_validate_config -->|"mounts"| cm_diracx_validate_config
5254
job_diracx_validate_config -->|"mounts"| cm_diracx_container_entrypoint
5355
job_diracx_validate_config -->|"env"| secret_diracx_secrets
56+
cronjob_diracx_cleanup_authdb -->|"mounts"| cm_diracx_cleanup_authdb
57+
cronjob_diracx_cleanup_authdb -->|"mounts"| cm_diracx_container_entrypoint
58+
cronjob_diracx_cleanup_authdb -->|"env"| secret_diracx_secrets
5459

5560
%% Styling
5661
classDef ing fill:#4a90d9,stroke:#2563eb,color:#ffffff
@@ -62,10 +67,12 @@ flowchart TD
6267
classDef cm fill:#7ec8e3,stroke:#2563eb,color:#1a1a2e
6368
classDef secret fill:#a78bfa,stroke:#2563eb,color:#ffffff
6469
classDef sa fill:#94a3b8,stroke:#2563eb,color:#ffffff
70+
class cm_diracx_cleanup_authdb cm
6571
class cm_diracx_container_entrypoint cm
6672
class cm_diracx_init_keystore cm
6773
class cm_diracx_validate_config cm
6874
class cm_mysql_init_diracx_dbs cm
75+
class cronjob_diracx_cleanup_authdb cronjob
6976
class deploy_diracx deploy
7077
class deploy_diracx_web deploy
7178
class ing_diracx ing

docs/admin/reference/values.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
| cert-manager.enabled | bool | `true` | |
2525
| cert-manager.installCRDs | bool | `true` | |
2626
| cert-manager.startupapicheck.enabled | bool | `true` | |
27-
| cleanupAuthDB.enabled | bool | `true` | |
28-
| cleanupAuthDB.schedule | string | `"0 0 1 * *"` | |
27+
| cleanupAuthDB.enabled | bool | `true` | Enable the AuthDB cleanup CronJob |
28+
| cleanupAuthDB.schedule | string | `"0 0 1 * *"` | Cron schedule for AuthDB cleanup (default: monthly on the 1st) |
2929
| developer.autoReload | bool | `true` | Enable automatic reloading inside uvicorn when the sources change Used by the integration tests for running closer to prod setup |
3030
| developer.editableMountedPythonModules | bool | `true` | Use pip install -e for mountedPythonModulesToInstall This is used by the integration tests because editable install might behave differently |
3131
| developer.enableCoverage | bool | `false` | Enable collection of coverage reports (intended for CI usage only) |

0 commit comments

Comments
 (0)