Skip to content

Commit d2fc6e1

Browse files
committed
feat(diracx-web): future proof modules size limit and add port env var
feat(diracx-web): increase node modules size limit feat(diracx-web): environment variables for port configuration feat(diracx-web): future proof node_module size limit
1 parent a03d259 commit d2fc6e1

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

diracx/templates/diracx-web/deployment.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ spec:
3838
# start from a clean state
3939
- name: diracx-web-scratch-node-modules
4040
emptyDir:
41-
sizeLimit: 1Gi
41+
sizeLimit: 2Gi
4242
- name: diracx-web-scratch-next
4343
emptyDir:
4444
sizeLimit: 1Gi
@@ -136,10 +136,12 @@ spec:
136136
{{- if $nodeDevInstall }}
137137
# Start the node module in development mode
138138
image: {{ .Values.developer.nodeImage }}
139-
command: ["npm", "run", "dev", "--prefix", "{{ $nodeMountedModulePath }}", "--", "-p", "{{ .Values.diracxWeb.service.port }}"]
139+
command: ["npm", "run", "dev", "--prefix", "{{ $nodeMountedModulePath }}"]
140140
env:
141141
- name: NEXT_TELEMETRY_DISABLED
142142
value: "1"
143+
- name: PORT
144+
value: "{{ .Values.diracxWeb.service.port }}"
143145
volumeMounts:
144146
- mountPath: "{{ $nodeMountedModulePath }}"
145147
name: "diracx-web-code-mount"

0 commit comments

Comments
 (0)