Skip to content

feat: add a cronjob to cleanup the authdb tables#241

Merged
aldbr merged 4 commits into
DIRACGrid:masterfrom
HeloiseJoffe:feat/authdb-cleanup-cronjob
Apr 1, 2026
Merged

feat: add a cronjob to cleanup the authdb tables#241
aldbr merged 4 commits into
DIRACGrid:masterfrom
HeloiseJoffe:feat/authdb-cleanup-cronjob

Conversation

@HeloiseJoffe

@HeloiseJoffe HeloiseJoffe commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Related to DIRACGrid/diracx#815
Related to #222

Changes:

  • Add a Kubernetes CronJob
  • Add Documentations

fstagni
fstagni reviewed Mar 4, 2026
View reviewed changes
Comment thread k3s/README.md Outdated
natthan-pigoux
natthan-pigoux reviewed Mar 4, 2026
View reviewed changes
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread docs/admin/how-to/install/installing.md Outdated
@natthan-pigoux

natthan-pigoux commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

You could also add a comment like here to explain that we can set: DIRACX_SERVICE_AUTH_REVOKED_REFRESH_TOKEN_RETENTION_DAYS and DIRACX_SERVICE_AUTH_COMPLETED_FLOW_RETENTION_MINUTES to tune the clean up by the cronJob.

natthan-pigoux
natthan-pigoux reviewed Mar 4, 2026
View reviewed changes
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
Comment thread k3s/manifest/cleanup-authdb-cronjob.yaml Outdated
@chrisburr chrisburr marked this pull request as draft March 5, 2026 07:47
@natthan-pigoux

natthan-pigoux commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think there was a confusion here. I just saw that you added the cron job in k3s/manifests, but I think it should go in diracx > templates > diracx > clean-auth-db

@HeloiseJoffe

HeloiseJoffe commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Yes I know I'm actually changing it

@HeloiseJoffe HeloiseJoffe force-pushed the feat/authdb-cleanup-cronjob branch 2 times, most recently from 4912881 to c2c6537 Compare March 10, 2026 09:29
@HeloiseJoffe

HeloiseJoffe commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

The pipeline is failing because the architecture diagram has changed with the addition of the new CronJob.
Here is the newly generated diagram:
architecture_diagram
Could someone with CERN access upload it to replace the current one?

@HeloiseJoffe HeloiseJoffe marked this pull request as ready for review March 10, 2026 10:13
@HeloiseJoffe HeloiseJoffe requested a review from aldbr March 10, 2026 10:13
natthan-pigoux
natthan-pigoux previously approved these changes Mar 11, 2026
View reviewed changes

@natthan-pigoux natthan-pigoux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HeloiseJoffe , looks fine for me now.

aldbr
aldbr requested changes Mar 11, 2026
View reviewed changes

@aldbr aldbr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HeloiseJoffe, I just have very minor comments 🙂
@chrisburr could you explain me how we are supposed to upload the new diagram please?

Comment thread k3s/README.md
Comment thread diracx/templates/diracx/cleanup-authdb/cronjob.yaml Outdated
Comment thread diracx/templates/diracx/cleanup-authdb/cronjob.yaml
@DIRACGridBot DIRACGridBot marked this pull request as draft March 11, 2026 17:46
@HeloiseJoffe HeloiseJoffe force-pushed the feat/authdb-cleanup-cronjob branch from 55a52be to 4b835fb Compare March 18, 2026 13:54
@HeloiseJoffe HeloiseJoffe marked this pull request as ready for review March 18, 2026 14:08
@HeloiseJoffe HeloiseJoffe requested a review from aldbr March 18, 2026 14:08
aldbr
aldbr previously approved these changes Mar 18, 2026
View reviewed changes
@aldbr aldbr linked an issue Mar 18, 2026 that may be closed by this pull request
Cleanup of the AuthDB tables #222
Closed
natthan-pigoux
natthan-pigoux requested changes Mar 18, 2026
View reviewed changes
Comment thread diracx/templates/diracx/cleanup-authdb/cronjob.yaml
@DIRACGridBot DIRACGridBot marked this pull request as draft March 18, 2026 15:20
@aldbr

aldbr commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

The diracx related PR has been merged. I think we now need to wait for a new diracx release within the charts to merge this one I guess, because the cleanup function does not exist yet.

natthan-pigoux
natthan-pigoux previously approved these changes Mar 19, 2026
View reviewed changes
@aldbr aldbr marked this pull request as ready for review March 19, 2026 10:06
@aldbr aldbr dismissed stale reviews from natthan-pigoux and themself via 680b798 March 25, 2026 08:50
@aldbr aldbr force-pushed the feat/authdb-cleanup-cronjob branch from 4b835fb to 680b798 Compare March 25, 2026 08:50
@aldbr aldbr mentioned this pull request Mar 31, 2026
Merged
@aldbr aldbr mentioned this pull request Mar 31, 2026
Closed
@aldbr aldbr force-pushed the feat/authdb-cleanup-cronjob branch 3 times, most recently from 03e9d6d to 5cc29b3 Compare April 1, 2026 14:11
@aldbr aldbr force-pushed the feat/authdb-cleanup-cronjob branch from 5cc29b3 to 44344bf Compare April 1, 2026 14:20
@aldbr aldbr enabled auto-merge (squash) April 1, 2026 14:21
@aldbr aldbr merged commit 5471132 into DIRACGrid:master Apr 1, 2026
9 checks passed
@HeloiseJoffe HeloiseJoffe deleted the feat/authdb-cleanup-cronjob branch April 22, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fstagni fstagni fstagni left review comments
@aldbr aldbr aldbr approved these changes
@natthan-pigoux natthan-pigoux natthan-pigoux left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup of the AuthDB tables

4 participants

@HeloiseJoffe @natthan-pigoux @aldbr @fstagni