feat: add pre-run-hook for entrypoint#277
Draft
HeloiseJoffe wants to merge 2 commits into
Draft
Conversation
HeloiseJoffe
force-pushed
the
feat/pre-run-hook-entrypoint
branch
from
a5498af to
7d6f363
Compare
sfayer
requested changes
Jul 6, 2026
sfayer
left a comment
sfayer
left a comment
Member
There was a problem hiding this comment.
Hi,
This generally looks good to me, although I wonder whether the hook file is actually needed in the charts now? It isn't clear to me whether it's doing anything useful, or whether having a placeholder there makes it easier for other users to override?
Regards,
Simon
| "helm.sh/resource-policy": keep | ||
| data: | ||
| entrypoint.sh: | | ||
| pre-run-hook.sh: | |
Member
There was a problem hiding this comment.
Are these steps still needed? It seems that if they are required the should probably be in the base entrypoint.sh unless there is a good reason to keep them here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
Change:
Replace
entrypoint.shwithpre-run-hook.sh