Skip to content

feat: new Search Bar for the Job Monitor#366

Merged
aldbr merged 1 commit into
DIRACGrid:mainfrom
TheauW:twartel-replace-filters
Jul 16, 2025
Merged

feat: new Search Bar for the Job Monitor#366
aldbr merged 1 commit into
DIRACGrid:mainfrom
TheauW:twartel-replace-filters

Conversation

@TheauW
Copy link
Copy Markdown
Contributor

@TheauW TheauW commented Jun 19, 2025

With this PR, I introduce a new component: the SearchBar.

It’s a search bar similar to the one on the GitLab website.
It provides suggestions as the user types and supports free-text input.

I’ve integrated this bar into the Job Monitor, replacing the old form.
Filters can now be applied directly through this new interface.

The same component will also be used in the Bookkeeping Browser and the Pilot Monitor, and possibly elsewhere in the future.

The SearchBar is fully configurable.

Comment thread packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx Outdated
Comment thread packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/Utils.tsx Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/Utils.tsx Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/SearchField.tsx Outdated
Comment thread packages/diracx-web-components/src/types/SearchBarEquation.ts Outdated
Comment thread packages/diracx-web-components/stories/JobMonitor.stories.tsx
@TheauW TheauW force-pushed the twartel-replace-filters branch 4 times, most recently from c87d35b to 9479147 Compare June 30, 2025 06:42
Copy link
Copy Markdown
Contributor

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thank you 🙂
Could you add some documentation please? May be in /docs/user/monitor_jobs.md about how to best use the search bar.

Comment thread packages/diracx-web/test/e2e/jobMonitor.cy.ts
Comment thread packages/diracx-web/test/e2e/jobMonitor.cy.ts
Comment thread packages/diracx-web/test/e2e/jobMonitor.cy.ts
Comment thread packages/diracx-web/test/e2e/jobMonitor.cy.ts
Comment thread packages/diracx-web/test/e2e/jobMonitor.cy.ts
Comment thread packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/components/JobMonitor/jobDataService.ts Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx Outdated
@aldbr
Copy link
Copy Markdown
Contributor

aldbr commented Jul 11, 2025

Just one last comment, do we still need InternalFilter?

@TheauW TheauW force-pushed the twartel-replace-filters branch from 9479147 to 5534bea Compare July 15, 2025 06:59
Comment thread docs/user/monitor_jobs.md Outdated
Comment thread packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx Outdated
Comment thread packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx Outdated
Comment thread packages/diracx-web-components/src/types/SearchBarToken.ts Outdated
Comment thread packages/diracx-web-components/src/types/SearchBarToken.ts Outdated
Comment thread packages/diracx-web-components/src/types/SearchBarToken.ts Outdated
Comment thread packages/diracx-web-components/src/types/SearchBarNatures.ts
Comment thread packages/diracx-web-components/src/types/JobMonitorTypes.ts
Comment thread packages/diracx-web-components/src/global.d.ts Outdated
@TheauW TheauW force-pushed the twartel-replace-filters branch from 8fa2b2a to db1d498 Compare July 15, 2025 13:20
@TheauW TheauW force-pushed the twartel-replace-filters branch from db1d498 to 8c759ae Compare July 15, 2025 13:24
@aldbr aldbr merged commit 4bbc9a9 into DIRACGrid:main Jul 16, 2025
14 of 15 checks passed
@TheauW TheauW deleted the twartel-replace-filters branch July 16, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants