chore: looks ok

Author: chaen

diracx-core/src/diracx/core/settings.py

@@ -380,6 +380,9 @@ class FactorySettings(ServiceSettingsBase):
     """The hashed API key for the legacy exchange endpoint.
     """
 
+    diracx_tasks_redis_url: str = "redis://localhost"
+    """The url for the redis server to manage tasks"""
+
     enabled_services: dict[str, bool] = Field(default_factory=dict)
     """The following environment variables dictates which routers are enabled."""
 

diracx-tasks/src/diracx/tasks/task_run.py

@@ -28,7 +28,7 @@
     from .plumbing._redis_types import LockCoordinator
 
 DEFAULT_REDIS_URL = "redis://localhost"
-REDIS_URL_ENV_VAR = "DIRACX_TASKS_REDIS_URL"
+_factory_settings = FactorySettings()
 
 
 class DebugOptions(StrEnum):
@@ -41,7 +41,8 @@ def _get_redis_url(args: argparse.Namespace) -> str:
     """Resolve Redis URL from CLI arg, env var, or default."""
     if hasattr(args, "redis_url") and args.redis_url:
         return args.redis_url
-    return os.environ.get(REDIS_URL_ENV_VAR, DEFAULT_REDIS_URL)
+
+    return _factory_settings.diracx_tasks_redis_url
 
 
 def main() -> None:
@@ -108,7 +109,7 @@ def main() -> None:
         "--redis-url",
         type=str,
         default=None,
-        help=f"Redis URL (default: ${REDIS_URL_ENV_VAR} or {DEFAULT_REDIS_URL})",
+        help=f"Redis URL (default: ${{REDIS_URL_ENV_VAR}} or {DEFAULT_REDIS_URL})",
     )
     submit_parser.set_defaults(
         func=lambda args: asyncio.run(
@@ -133,7 +134,7 @@ def main() -> None:
         "--redis-url",
         type=str,
         default=None,
-        help=f"Redis URL (default: ${REDIS_URL_ENV_VAR} or {DEFAULT_REDIS_URL})",
+        help=f"Redis URL (default: ${{REDIS_URL_ENV_VAR}} or {DEFAULT_REDIS_URL})",
     )
     worker_parser.add_argument(
         "--worker-size",
@@ -160,7 +161,7 @@ def main() -> None:
         "--redis-url",
         type=str,
         default=None,
-        help=f"Redis URL (default: ${REDIS_URL_ENV_VAR} or {DEFAULT_REDIS_URL})",
+        help=f"Redis URL (default: ${{REDIS_URL_ENV_VAR}} or {DEFAULT_REDIS_URL})",
     )
     scheduler_parser.set_defaults(
         func=lambda args: asyncio.run(start_scheduler(redis_url=_get_redis_url(args)))
@@ -242,7 +243,7 @@ async def start_scheduler(redis_url: str) -> None:
     task_classes = load_task_registry()
 
     config = None
-    config_url = FactorySettings().diracx_config_backend_url
+    config_url = _factory_settings.diracx_config_backend_url
     if config_url:
         from diracx.core.config import ConfigSource
 
@@ -338,7 +339,7 @@ async def call_task(
 
     # Try to connect to Redis for lock acquisition
     redis: LockCoordinator | None = None
-    redis_url = os.environ.get(REDIS_URL_ENV_VAR)
+    redis_url = _factory_settings.diracx_tasks_redis_url
     if redis_url:
         from redis.asyncio import Redis
 

docs/admin/reference/env-variables.md

@@ -28,6 +28,11 @@ The URL of the configuration backend.
 *Optional*, default value: \`\`
 The hashed API key for the legacy exchange endpoint.
 
+### `DIRACX_TASKS_REDIS_URL`
+
+*Optional*, default value: `redis://localhost`
+The url for the redis server to manage tasks
+
 ### `ENABLED_SERVICES`
 
 *Optional*