fix: handle device flow errors

[HeloiseJoffe]

Closes #559

Changes:

• Replace the NotImplementedError with IAMServerError in the get_server_metadata function
• Add error handling in the do_device_flow routers endpoint for NoResultFound, ValueError and IAMServerError

Question:
The issue mentioned: "do we need to keep diracx.routers.auth.util? (has_properties function)"
After looking at the codebase, I think has_properties is not needed since access policies (WMSAccessPolicy, SandboxAccessPolicy ...) already handle property checks.
However, I'm not sure if the removing of this function should be done here or in a separate PR?
What do you think about it ?

[aldbr]

After looking at the codebase, I think has_properties is not needed since access policies (WMSAccessPolicy, SandboxAccessPolicy ...) already handle property checks.

I think you are right indeed, it's not used anymore anywhere, just referenced in the document and I presume it should be deleted.

@chaen @chrisburr any opinion?

[read-the-docs-community]

Documentation build overview

📚 diracx | 🛠️ Build #32526160 | 📁 Comparing 98b0487 against latest (3daf914)

  🔍 Preview build  

3 files changed

± admin/explanations/architecture_diagram/index.html
± admin/explanations/chart-structure/index.html
± dev/reference/dependency-injection/index.html

[aldbr]

After looking at the codebase, I think has_properties is not needed since access policies (WMSAccessPolicy, SandboxAccessPolicy ...) already handle property checks.

I think you are right indeed, it's not used anymore anywhere, just referenced in the document and I presume it should be deleted.

@chaen @chrisburr any opinion?

After discussing with @chaen, we agreed that it could be deleted, and I think you can do it as part of this PR.
Is that ok for you @HeloiseJoffe?