Skip to content

fix(route/thepaper)(route/jiemian): remove useless image and audio #21800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DIYgod merged 7 commits into from
May 7, 2026
Merged

fix(route/thepaper)(route/jiemian): remove useless image and audio #21800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e7213a
Comment out media object in rss_item
HamadaMasatoshi Apr 21, 2026
abc5624
Disable voiceInfo handling in RSS item
HamadaMasatoshi Apr 21, 2026
ae9c85d
Update description extraction to exclude report view
HamadaMasatoshi Apr 27, 2026
c1195fc
Merge branch 'DIYgod:master' into master
HamadaMasatoshi Apr 27, 2026
bdd71fb
Refactor description logic in common.tsx
HamadaMasatoshi Apr 27, 2026
34909cd
Handle missing featured image in description logic
HamadaMasatoshi Apr 27, 2026
fbca532
Improve description extraction in common.tsx
HamadaMasatoshi May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion lib/routes/jiemian/common.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,23 @@ export const handler = async (ctx): Promise<Data> => {
}
: undefined,
intro: content('div.article-header p').text(),
description: content('div.article-content').html(),
description: (() => {
const featuredImageSrc = image.prop('src');
if (!featuredImageSrc) {
// 如果没有 featured image，直接返回原始内容
const descContent = content('div.article-content').clone();
descContent.find('p.report-view').remove();
return descContent.html();
}
const baseImageName = featuredImageSrc.replace(/_[^.]+(\.\w+)$/, '$1');
const descContent = content('div.article-content').clone();
descContent.find('p.report-view').remove();
if (baseImageName && baseImageName !== featuredImageSrc) {
descContent.find(`img[src="${baseImageName}"]`).remove();
}
return descContent.html();
})(),

});
item.author = content('span.author')
.first()
Expand Down
26 changes: 13 additions & 13 deletions lib/routes/thepaper/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,20 @@ export default {
category: [...(contentDetail.tagList?.map((t) => t.tag) ?? []), contentDetail?.nodeInfo?.name ?? []],
pubDate,
author: contentDetail.author || '',
media: {
content: {
url: item.pic || contentDetail.videos?.coverUrl || contentDetail.bigPic,
},
thumbnails: {
url: item.sharePic || contentDetail.sharePic,
},
},
// media: {
// content: {
// url: item.pic || contentDetail.videos?.coverUrl || contentDetail.bigPic,
// },
// thumbnails: {
// url: item.sharePic || contentDetail.sharePic,
// },
// },
Comment thread
HamadaMasatoshi marked this conversation as resolved.
};
if (contentDetail.voiceInfo?.isHaveVoice) {
rss_item.enclosure_type = 'audio/mpeg';
rss_item.enclosure_url = contentDetail.voiceInfo.voiceSrc;
rss_item.itunes_item_image = item.pic || contentDetail.videos?.coverUrl;
}
// if (contentDetail.voiceInfo?.isHaveVoice) {
// rss_item.enclosure_type = 'audio/mpeg';
// rss_item.enclosure_url = contentDetail.voiceInfo.voiceSrc;
// rss_item.itunes_item_image = item.pic || contentDetail.videos?.coverUrl;
// }
Comment on lines +73 to +77
Copy link
Copy Markdown
Collaborator

@TonyRL TonyRL May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podcast is added since #10859. There are people who love listening to RSS feeds. Folo also provides a TTS feature for RSS content for those people. Taking this feature away from them is obviously a big NO.

Copy link
Copy Markdown
Author

@HamadaMasatoshi HamadaMasatoshi May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry , it is my fault.

However , Please STOP marketing that expensive and unstable rss reader in this project , and focus on RSSHub itself.

I will maintain a separate branch for my own needs.

Copy link
Copy Markdown
Owner

@DIYgod DIYgod May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll happily give up the expensive reader if you're willing to pay the maintainers, otherwise shut up

Copy link
Copy Markdown
Author

@HamadaMasatoshi HamadaMasatoshi May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll happily give up the expensive reader if you're willing to pay the maintainers, otherwise shut up

Yes , I paid the maintainer .

REMEMBER YOUR WORD .

Give Up The Expensive Reader Right Now !


image

Copy link
Copy Markdown
Owner

@DIYgod DIYgod May 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll give it up for 0.1 hour. You deserve it.

But even at this point, you're still unwilling to make recurring payments.

Copy link
Copy Markdown

@ghost ghost May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll give it up for 0.1 hour. You deserve it.

But even at this point, you're still unwilling to make recurring payments.

收了钱又把人拉黑，什么乞丐行为，肉包子喂狗还知道叫两声呢

return rss_item;
});
},
Expand Down