Rename the observations variable in the evaluation util to avoid shadowing#1288
Merged
Conversation
…owing This enables a callback in evaluate_policy to have access to the observation vector that is fed to the environment step function, which is currently shadowed by the output observation.
araffin
reviewed
Apr 3, 2023
araffin
left a comment
Member
There was a problem hiding this comment.
LGTM =)
Could you update the changelog and do a PR to update SB3 contrib repo too? (see PR template)
Sorry for the delay, I was focused on the gym/gymnasium transition...
15 tasks
Contributor
Author
Sorry about that, I missed both of these... |
araffin
approved these changes
Apr 11, 2023
araffin
left a comment
Member
There was a problem hiding this comment.
LGTM, please apply the changes I did to the SB3 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple renaming. It enables a callback in evaluate_policy to have access to the observation vector that is fed to the environment step function, which is currently shadowed by the output observation.
Description
Motivation and Context
Closes #1287
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line