Refactor: handle logo and shibboleth w/ helpers

This refactor is meant to serve as a small step in simplifying  `OrgsController#admin_update` controller action, which currently contains a lot of rubocop offences.

- Moved `attrs[:logo]` handling logic into `handle_logo(attrs)`

- Moved Shibboleth identifier handling into `handle_shibboleth_identifier(attrs)`

Author: aaronskiba

app/controllers/orgs_controller.rb

@@ -33,41 +33,17 @@ def admin_update
     @org = Org.find(params[:id])
     authorize @org
 
-    # If a new logo was supplied then use it, otherwise retain the existing one
-    attrs[:logo] = attrs[:logo].present? ? attrs[:logo] : @org.logo
-    # Remove the logo if the user checked the box
-    attrs[:logo] = nil if attrs[:remove_logo] == '1'
+    attrs = handle_logo(attrs)
 
     tab = (attrs[:feedback_enabled].present? ? 'feedback' : 'profile')
     @org.links = ActiveSupport::JSON.decode(params[:org_links]) if params[:org_links].present?
 
     # Only allow super admins to change the org types and shib info
     if current_user.can_super_admin?
-      identifiers = []
       attrs = handle_managed_flag(attrs)
+      attrs = handle_shibboleth_identifier(attrs)
 
-      # Handle Shibboleth identifier if that is enabled
-      if Rails.configuration.x.shibboleth.use_filtered_discovery_service
-        shib = IdentifierScheme.by_name('shibboleth').first
-
-        if shib.present? && attrs[:identifiers_attributes].present?
-          key = attrs[:identifiers_attributes].keys.first
-          entity_id = attrs[:identifiers_attributes][:"#{key}"][:value]
-          # rubocop:disable Metrics/BlockNesting
-          if entity_id.present?
-            identifier = Identifier.find_or_initialize_by(
-              identifiable: @org, identifier_scheme: shib, value: entity_id
-            )
-            @org = process_identifier_change(org: @org, identifier: identifier)
-          else
-            # The user blanked out the entityID so delete the record
-            @org.identifier_for_scheme(scheme: shib)&.destroy
-          end
-          # rubocop:enable Metrics/BlockNesting
-        end
-        attrs.delete(:identifiers_attributes)
-      end
-
+      identifiers = []
       # See if the user selected a new Org via the Org Lookup and
       # convert it into an Org
       lookup = org_from_params(params_in: attrs)
@@ -236,6 +212,14 @@ def search_params
     params.require(:org).permit(:name, :type)
   end
 
+  def handle_logo(attrs)
+    # If a new logo was supplied then use it, otherwise retain the existing one
+    attrs[:logo] = attrs[:logo].present? ? attrs[:logo] : @org.logo
+    # Remove the logo if the user checked the box
+    attrs[:logo] = nil if attrs[:remove_logo] == '1'
+    attrs
+  end
+
   def handle_managed_flag(attrs)
     # NOTE: The :managed param is controlled by a check_box in the form
     #       `app/views/orgs/_profile_form.html.erb`.
@@ -245,6 +229,29 @@ def handle_managed_flag(attrs)
     attrs
   end
 
+  # Updates the @org's Shibboleth identifier(s) if the required conditions are met
+  def handle_shibboleth_identifier(attrs)
+    return attrs unless Rails.configuration.x.shibboleth.use_filtered_discovery_service
+
+    shib = IdentifierScheme.by_name('shibboleth').first
+
+    if shib.present? && attrs[:identifiers_attributes].present?
+      key = attrs[:identifiers_attributes].keys.first
+      entity_id = attrs[:identifiers_attributes][:"#{key}"][:value]
+      if entity_id.present?
+        identifier = Identifier.find_or_initialize_by(
+          identifiable: @org, identifier_scheme: shib, value: entity_id
+        )
+        @org = process_identifier_change(org: @org, identifier: identifier)
+      else
+        # The user blanked out the entityID so delete the record
+        @org.identifier_for_scheme(scheme: shib)&.destroy
+      end
+    end
+    attrs.delete(:identifiers_attributes)
+    attrs
+  end
+
   def shib_login_url
     shib_login = Rails.configuration.x.shibboleth.login_url
     "#{request.base_url.gsub('http:', 'https:')}#{shib_login}"